<div><div>Same comments as Tony and Richard, I'm definitely +1 on the proposal, but I find the directory-related flags confusingly named.</div><div><br></div><div>I think Tony's suggestion is interesting, but `-working-directory` is still confusing, it could fit both uses, so maybe instead something like:</div><div><br></div><div>-build-directory : change before any operation (assuming the only operations besides running the executable is to build it?)</div><div><br></div><div>-run-directory : working directory to run the executable</div><div><br></div><div>However, I understand that -chdir is already supported by existing commands to change the working directory before any other operation, so maybe just rename -in-dir to -run-directory would make sense. Or use the directory provided to -chdir as both the build and run directories and drop the -in-dir flag (after all, this is a convenience operation that combines build and run by default, you can always build separately, then run with -skip-build).</div><div><br></div><div>Thinking out loud a bit, but the basic idea is that those 2 flags are confusing, but the rest looks good to me.</div><div><br></div><div>Martin</div><div><br><div class="gmail_quote"><div>On Wed, May 17, 2017 at 08:07 Tony Arnold via swift-evolution <<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> On 17 May 2017, at 20:32, Richard Wei via swift-evolution <<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>> wrote:<br>
><br>
> Excellent, except that `--chdir` and `--in-dir` are confusing. Why not use a long, clear name, just like `—enable-prefetching`? Consider `—working-dir` & `—preexec-working-dir`<br>
<br>
That would be my one bit of feedback as well. The names of these two parameters aren’t descriptive.<br>
<br>
My suggestions would be:<br>
<br>
--working-directory, -w Change working directory before any other operation<br>
--run-directory, -r Change working directory before running the executable<br>
<br>
I don’t believe there’s any reason to shorten or truncate the full parameters if you’re going to offer a single-character alias for them.<br>
<br>
Otherwise, top proposal! 5 stars, would review again ;)<br>
<br>
I’m +1 for SE-0179.<br>
<br>
<br>
-t<br>
<br>
<br>
<br>
----------<br>
Tony Arnold<br>
+61 411 268 532<br>
<a href="http://thecocoabots.com/" rel="noreferrer" target="_blank">http://thecocoabots.com/</a><br>
<br>
ABN: 14831833541<br>
<br>
_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
</blockquote></div></div></div>