<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><p class="" style="-webkit-print-color-adjust: exact; margin: 15px 0px;"><span style="background-color: rgba(255, 255, 255, 0);">review of SE-0173 "Add MutableCollection.swap(_:with:)" </span></p><ul class="" style="-webkit-print-color-adjust: exact; margin: 15px 0px; padding-left: 30px;"><li class="" style="-webkit-print-color-adjust: exact; margin: 0px;"><span style="background-color: rgba(255, 255, 255, 0);">What is your evaluation of the proposal?</span></li></ul><div>Good idea. Reads better than current global swap. </div><ul class="" style="-webkit-print-color-adjust: exact; margin: 15px 0px; padding-left: 30px;"><li class="" style="-webkit-print-color-adjust: exact; margin: 0px;"><span style="background-color: rgba(255, 255, 255, 0);">Is the problem being addressed significant enough to warrant a change to Swift?</span></li></ul><div>Probably; It will become significant once control over ARC added, though not needed just yet. </div><ul class="" style="-webkit-print-color-adjust: exact; margin: 15px 0px; padding-left: 30px;"><li class="" style="-webkit-print-color-adjust: exact; margin: 0px;"><span style="background-color: rgba(255, 255, 255, 0);">Does this proposal fit well with the feel and direction of Swift?</span></li></ul><div>Yes. The global functions do not sit well with Swift. Methods read much better. Could just eliminate current swap and not replace it though. You can write `(a[i], a[j]) = <span style="background-color: rgba(255, 255, 255, 0);">(a[j], a[i])` instead. </span></div><ul class="" style="-webkit-print-color-adjust: exact; margin: 15px 0px; padding-left: 30px;"><li class="" style="-webkit-print-color-adjust: exact; margin: 0px;"><span style="background-color: rgba(255, 255, 255, 0);">If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</span></li></ul><div>Yes. People write similar functions in Java, though not in standard library. </div><ul class="" style="-webkit-print-color-adjust: exact; margin: 15px 0px; padding-left: 30px;"><li class="" style="-webkit-print-color-adjust: exact; margin: 0px;"><span style="background-color: rgba(255, 255, 255, 0);">How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</span></li></ul><p class="" style="-webkit-print-color-adjust: exact; margin: 15px 0px;">Quick read</p><br>-- Howard. </div><div><br>On 26 Apr 2017, at 4:32 am, Ted Kremenek <<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>> wrote:<br><br></div><blockquote type="cite"><div><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">review of SE-0173 "Add MutableCollection.swap(_:with:)" begins now and runs <span>through </span><strong style="-webkit-print-color-adjust: exact;" class=""><span>April 28, 2017</span></strong>.</p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">The proposal is available here:</p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class=""><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md" style="-webkit-print-color-adjust: exact; color: rgb(65, 131, 196);" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md</a></p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:</p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class=""><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" class="">https://lists.swift.org/mailman/listinfo/swift-evolution</a></p><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:</p><blockquote style="-webkit-print-color-adjust: exact; margin: 15px 0px; border-left-width: 4px; border-left-style: solid; border-left-color: rgb(221, 221, 221); padding: 0px 15px; color: rgb(119, 119, 119); font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class=""><h3 id="toc_0" style="-webkit-print-color-adjust: exact; margin: 0px 0px 10px; padding: 0px; -webkit-font-smoothing: antialiased; cursor: text; position: relative; font-size: 18px;" class="">Proposal link:</h3><blockquote style="-webkit-print-color-adjust: exact; margin: 15px 0px 0px; border-left-width: 4px; border-left-style: solid; border-left-color: rgb(221, 221, 221); padding: 0px 15px;" class=""><p style="-webkit-print-color-adjust: exact; margin: 0px 0px 15px;" class=""><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md</a></p><h3 id="toc_1" style="-webkit-print-color-adjust: exact; margin: 20px 0px 10px; padding: 0px; -webkit-font-smoothing: antialiased; cursor: text; position: relative; font-size: 18px;" class="">Reply text</h3><p style="-webkit-print-color-adjust: exact; margin: 15px 0px 0px;" class="">Other replies</p></blockquote></blockquote><h3 id="toc_2" style="-webkit-print-color-adjust: exact; margin: 20px 0px 10px; padding: 0px; -webkit-font-smoothing: antialiased; cursor: text; position: relative; font-size: 18px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">What goes into a review?</h3><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:</p><ul style="-webkit-print-color-adjust: exact; margin: 15px 0px; padding-left: 30px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class=""><li style="-webkit-print-color-adjust: exact; margin: 0px;" class="">What is your evaluation of the proposal?</li><li style="-webkit-print-color-adjust: exact; margin: 0px;" class="">Is the problem being addressed significant enough to warrant a change to Swift?</li><li style="-webkit-print-color-adjust: exact; margin: 0px;" class="">Does this proposal fit well with the feel and direction of Swift?</li><li style="-webkit-print-color-adjust: exact; margin: 0px;" class="">If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</li><li style="-webkit-print-color-adjust: exact; margin: 0px;" class="">How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</li></ul><p style="-webkit-print-color-adjust: exact; margin: 15px 0px; font-family: -apple-system-body, Helvetica, arial, sans-serif; background-color: rgb(255, 255, 255);" class="">M</p></div></blockquote></body></html>