Excellently written proposal, sensible motivation.<br><br>Only nit is that `with` is not required and is better off removed, IMO. Here's why:<br><br>* "swap a and b" and "swap a with b" are equivalent statements<br>* there's no reason to use one phrasing for the free function and another with this method; the difference is in taking indices vs. inout values, but the relationship between a and b is preserved<br>* the former spelling emphasizes the symmetry of the operation, which I believe is in line with API naming guidelines on labels<br>* the former spelling is also terser<br><br><div class="gmail_quote"><div dir="ltr">On Tue, Apr 25, 2017 at 13:32 Ted Kremenek via swift-evolution <<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><p style="margin-right:0px;margin-bottom:15px;margin-left:0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255);margin-top:0px!important">Hello Swift community,</p><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">The review of SE-0173 "Add MutableCollection.swap(_:with:)" begins now and runs through <strong>April 28, 2017</strong>.</p><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">The proposal is available here:</p><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md" style="color:rgb(65,131,196)" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md</a></p><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:</p><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a></p><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:</p><blockquote style="margin:15px 0px;border-left-width:4px;border-left-style:solid;border-left-color:rgb(221,221,221);padding:0px 15px;color:rgb(119,119,119);font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><h3 id="m_1474118603412800430toc_0" style="margin:0px 0px 10px;padding:0px;font-size:18px">Proposal link:</h3><blockquote style="margin:15px 0px 0px;border-left-width:4px;border-left-style:solid;border-left-color:rgb(221,221,221);padding:0px 15px"><p style="margin:0px 0px 15px"><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md</a></p><h3 id="m_1474118603412800430toc_1" style="margin:20px 0px 10px;padding:0px;font-size:18px">Reply text</h3><p style="margin:15px 0px 0px">Other replies</p></blockquote></blockquote><h3 id="m_1474118603412800430toc_2" style="margin:20px 0px 10px;padding:0px;font-size:18px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">What goes into a review?</h3><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:</p><ul style="margin:15px 0px;padding-left:30px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><li style="margin:0px">What is your evaluation of the proposal?</li><li style="margin:0px">Is the problem being addressed significant enough to warrant a change to Swift?</li><li style="margin:0px">Does this proposal fit well with the feel and direction of Swift?</li><li style="margin:0px">If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</li><li style="margin:0px">How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</li></ul><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">More information about the Swift evolution process is available at:</p><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)"><a href="https://github.com/apple/swift-evolution/blob/master/process.md" style="color:rgb(65,131,196)" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a></p><p style="margin:15px 0px;font-family:-apple-system-body,Helvetica,arial,sans-serif;background-color:rgb(255,255,255)">Thank you,<br>Ted (Review Manager)</p></div>_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
</blockquote></div>