<div dir="ltr">+1 with the clarifications provided in the thread.</div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Apr 9, 2017 at 4:44 AM, Howard Lovatt via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div><span class=""><span style="background-color:rgba(255,255,255,0)">Review of SE-0168 "Multi-Line String Literals" </span></span><div><span style="background-color:rgba(255,255,255,0)"><br></span><span class=""><div><span style="background-color:rgba(255,255,255,0)"><span class="m_-4771046650319386067Apple-tab-span" style="white-space:pre-wrap"> </span>• What is your evaluation of the proposal?<br></span></div><div><span style="background-color:rgba(255,255,255,0)"><br></span></div></span><div><span style="background-color:rgba(255,255,255,0)">Yes good idea. Though I am not clear as to whether the final return before the closing """ is included in the literal or not. If not, would a blank line before """ enclose a return at the end. If yes, would the closing """ have to be on the same line to prevent a return at the end. It doesn't really matter which option, but it wasn't clear to me what happens. </span></div><span class=""><div><span style="background-color:rgba(255,255,255,0)"><br></span></div><div><span style="background-color:rgba(255,255,255,0)"><span class="m_-4771046650319386067Apple-tab-span" style="white-space:pre-wrap"> </span>• Is the problem being addressed significant enough to warrant a change to Swift?<br></span></div><div><span style="background-color:rgba(255,255,255,0)"><br></span></div></span><div><span style="background-color:rgba(255,255,255,0)">Yes. Very handy on server side code. </span></div><span class=""><div><span style="background-color:rgba(255,255,255,0)"><br></span></div><div><span style="background-color:rgba(255,255,255,0)"><span class="m_-4771046650319386067Apple-tab-span" style="white-space:pre-wrap"> </span>• Does this proposal fit well with the feel and direction of Swift?<br></span></div><div><span style="background-color:rgba(255,255,255,0)"><br></span></div></span><div><span style="background-color:rgba(255,255,255,0)">Yes, with the push onto server side it is a nice addition. </span></div><span class=""><div><span style="background-color:rgba(255,255,255,0)"><br></span></div><div><span style="background-color:rgba(255,255,255,0)"><span class="m_-4771046650319386067Apple-tab-span" style="white-space:pre-wrap"> </span>• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></span></div><div><span style="background-color:rgba(255,255,255,0)"><br></span></div></span><div><span style="background-color:rgba(255,255,255,0)">Yes. Lots of languages have similar. </span></div><span class=""><div><span style="background-color:rgba(255,255,255,0)"><br></span></div><div><span style="background-color:rgba(255,255,255,0)"><span class="m_-4771046650319386067Apple-tab-span" style="white-space:pre-wrap"> </span>• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br></span></div><div><span style="background-color:rgba(255,255,255,0)"><br></span></div></span><div><span style="background-color:rgba(255,255,255,0)">Quick read. </span></div><div><br></div></div><br>-- Howard.</div><span class=""><div><br>On 7 Apr 2017, at 5:35 am, Joe Groff <<a href="mailto:jgroff@apple.com" target="_blank">jgroff@apple.com</a>> wrote:<br><br></div><blockquote type="cite"><div>review of SE-0168 "Multi-Line String Literals" begins now and runs <span>through April 12, 2017</span>. The proposal is available here:<br><br><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0168-multi-line-string-literals.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>proposals/0168-multi-line-<wbr>string-literals.md</a></blockquote><div><br>Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:<br><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a></div><div><br></div></blockquote><div>or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:<br><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div>Proposal link:</div></blockquote><div><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0167-swift-encoders.md" target="_blank">https://github.com/apple/<wbr>swift-evolution/blob/master/<wbr>proposals/0167-swift-encoders.<wbr>md</a></div></blockquote></blockquote><div><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div>Reply text</div></blockquote><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div>Other replies</div></blockquote><div><br></div><div><b>What goes into a review?</b><br><br>The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br><br><div><span class="m_-4771046650319386067Apple-tab-span" style="white-space:pre-wrap"> </span>• What is your evaluation of the proposal?<br></div><div><span class="m_-4771046650319386067Apple-tab-span" style="white-space:pre-wrap"> </span>• Is the problem being addressed significant enough to warrant a change to Swift?<br></div><div><span class="m_-4771046650319386067Apple-tab-span" style="white-space:pre-wrap"> </span>• Does this proposal fit well with the feel and direction of Swift?<br></div><div><span class="m_-4771046650319386067Apple-tab-span" style="white-space:pre-wrap"> </span>• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></div><div><span class="m_-4771046650319386067Apple-tab-span" style="white-space:pre-wrap"> </span>• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br></div><div></div></div></div></blockquote></span></div><br>______________________________<wbr>_________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-<wbr>evolution</a><br>
<br></blockquote></div><br></div>