<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title></title>
</head>
<body>
<div name="messageBodySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;">
<div>
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<div class="">
<div class="">• What is your evaluation of the proposal?<br class="" /></div>
</div>
</blockquote>
<br />
I like the feature a lot, but I'm not so sure about the described indentation-stripping behavior. I don't think that putting the closing """ at the same indentation level as the string's contents is very intuitive. It feels a bit like writing this:</div>
<div><br /></div>
<div><font face="Menlo">if someCondition {</font></div>
<div><font face="Menlo">    print("message")</font></div>
<div><font face="Menlo">    }</font></div>
<div><br /></div>
<div>In general, the closing delimiter in a multiline context (for lack of a better general term) is indented to the same level as the line that contains the opening delimiter, so I think that unless developers are explicitly taught otherwise, they would likely default to that style for multiline strings, resulting in confusion about why there's an extra level of indentation in the interpreted multiline string.</div>
<div><br /></div>
<div>I think what would be more intuitive and stylistically flexible would be to strip the largest amount leading whitespace that is common to each line. In other words, whichever line(s) that have the least amount of leading whitespace would determine the amount of indentation that gets stripped.</div>
<div><br /></div>
<div>Apologies if this approach has been discussed before -- I missed most of the discussion that led to the proposal. Any thoughts on this?<br />
<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<div class="">
<div class="">• Is the problem being addressed significant enough to warrant a change to Swift?<br class="" /></div>
</div>
</blockquote>
<br />
Yes -- this would be a very useful feature in some situations.<br />
<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<div class="">
<div class="">• Does this proposal fit well with the feel and direction of Swift?<br class="" /></div>
</div>
</blockquote>
<br />
I think so.<br />
<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<div class="">
<div class="">• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br class="" /></div>
</div>
</blockquote>
<br />
I haven't used this feature enough in other languages to comment here.<br />
<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<div class="">
<div class="">• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</div>
</div>
</blockquote>
<br /></div>
<div>I read the proposal thoroughly.</div>
</div>
<div name="messageSignatureSection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;"><br />
Jarod</div>
<div name="messageReplySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;"><br />
On Apr 6, 2017, 12:35 -0700, Joe Groff via swift-evolution <swift-evolution@swift.org>, wrote:<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">Hello Swift community,<br class="" />
<br class="" />
The review of SE-0168 "Multi-Line String Literals" begins now and runs through April 12, 2017. The proposal is available here:<br class="" />
<br class="" />
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;" class=""><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0168-multi-line-string-literals.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0168-multi-line-string-literals.md</a></blockquote>
<div class=""><br class="" />
Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:<br class="" />
<br class="" /></div>
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;" class="">
<div class=""><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" class="">https://lists.swift.org/mailman/listinfo/swift-evolution</a></div>
<div class=""><br class="" /></div>
</blockquote>
<div class="">or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:<br class="" />
<br class="" /></div>
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;" class="">
<div class="">Proposal link:</div>
</blockquote>
<div class=""><br class="" /></div>
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;" class="">
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #3498db;" class="">
<div class=""><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0167-swift-encoders.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0167-swift-encoders.md</a></div>
</blockquote>
</blockquote>
<div class=""><br class="" /></div>
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;" class="">
<div class="">Reply text</div>
</blockquote>
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;" class="">
<div class="">Other replies</div>
</blockquote>
<div class=""><br class="" /></div>
<div class=""><b class="">What goes into a review?</b><br class="" />
<br class="" />
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br class="" />
<br class="" />
<div class="">• What is your evaluation of the proposal?<br class="" /></div>
<div class="">• Is the problem being addressed significant enough to warrant a change to Swift?<br class="" /></div>
<div class="">• Does this proposal fit well with the feel and direction of Swift?<br class="" /></div>
<div class="">• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br class="" /></div>
<div class="">• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br class="" /></div>
<div class=""><br class="" /></div>
More information about the Swift evolution process is available at:<br class="" />
<br class="" /></div>
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;" class="">
<div class=""><a href="https://github.com/apple/swift-evolution/blob/master/process.md" class="">https://github.com/apple/swift-evolution/blob/master/process.md</a></div>
</blockquote>
<div class=""><br class="" /></div>
<div class="">Thank you,</div>
<div class=""><br class="" />
-Joe<br class="" />
Review Manager<br class="" /></div>
_______________________________________________<br />
swift-evolution mailing list<br />
swift-evolution@swift.org<br />
https://lists.swift.org/mailman/listinfo/swift-evolution<br /></blockquote>
</div>
</body>
</html>