<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title></title>
</head>
<body>
<div name="messageBodySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;">
<div><br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<div class="">
<div class="">
<div class="">• What is your evaluation of the proposal?</div>
</div>
</div>
</blockquote>
<br />
<div>I think it's great! Enthusiastic +1 from me.<br /></div>
<div><br /></div>
<div>Just an idea -- in addition to `mapValues`, it seems like it would be useful to have both a `mapKeys` and plain `map` for key-value pairs. The proposal mentions that `map` was omitted because unique keys aren't guaranteed, but it seems reasonable to me to trap if duplicate keys are generated during a map, similar to how the proposed sequence-based initializer traps on duplicate keys.</div>
<div><br /></div>
<div>I don't think those additions are critical, but they seem nice to me.</div>
<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<div class="">
<div class="">
<div class="">• Is the problem being addressed significant enough to warrant a change to Swift?<br class="" /></div>
</div>
</div>
</blockquote>
<div><br /></div>
Yes -- I've struggled with several of the issues that the proposal addresses. The specialized map / filter, default subscript values, and merging are particularly appealing to me.</div>
<div><br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<div class="">
<div class="">
<div class="">• Does this proposal fit well with the feel and direction of Swift?<br class="" /></div>
</div>
</div>
</blockquote>
<div><br /></div>
I think so, since Swift already goes to great lengths to provide a robust collection system. This is a logical iteration of that idea.<br />
<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<div class="">
<div class="">
<div class="">• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br class="" /></div>
</div>
</div>
</blockquote>
<div><br /></div>
I don't recall any features I've used elsewhere that would be helpful to compare to.<br />
<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<div class="">
<div class="">
<div class="">• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</div>
</div>
</div>
</blockquote>
<br />
<div class="">
<div class="">
<div class="">I didn't follow any discussion that led to the proposal, but I read the whole thing.</div>
</div>
</div>
</div>
</div>
<div name="messageSignatureSection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;"><br />
Jarod</div>
<div name="messageReplySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;"><br />
On Apr 5, 2017, 17:45 -0700, Ben Cohen via swift-evolution <swift-evolution@swift.org>, wrote:<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">Hello, Swift community!<br class="" />
<br class="" />
The review of "SE-165: Dictionary & Set Enhancements" begins now and runs through next Tuesday, April 11th. The proposal is available here:
<div class=""><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0165-dict.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0165-dict.md</a></div>
<div class=""><br class="" /></div>
<div class="">
<div class="">Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at</div>
<div class=""><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" class="">https://lists.swift.org/mailman/listinfo/swift-evolution</a></div>
<div class=""><br class="" /></div>
<div class="">or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:</div>
<div class="">
<div class=""><br class="" />
Proposal link:  <a href="https://github.com/apple/swift-evolution/blob/master/proposals/0165-dict.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0165-dict.md</a></div>
<div class=""><br class="" /></div>
<div class="">Reply text</div>
<div class=""><br class="" />
Other replies</div>
</div>
<div class=""><br class="" /></div>
<div class=""><b class="">What goes into a review?</b><br class="" />
<br class="" />
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br class="" />
<br class="" />
<div class="">• What is your evaluation of the proposal?<br class="" /></div>
<div class="">• Is the problem being addressed significant enough to warrant a change to Swift?<br class="" /></div>
<div class="">• Does this proposal fit well with the feel and direction of Swift?<br class="" /></div>
<div class="">• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br class="" /></div>
<div class="">• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br class="" /></div>
<div class=""><br class="" /></div>
More information about the Swift evolution process is available at <a href="https://github.com/apple/swift-evolution/blob/master/process.md" class="">https://github.com/apple/swift-evolution/blob/master/process.md</a>
<div class=""><br class="" />
<div class="">Thank you,<br class="" />
<br class="" />
Ben Cohen<br class="" />
Review Manager</div>
<div class=""><br class="" /></div>
<div class=""><br class="" /></div>
</div>
</div>
</div>
_______________________________________________<br />
swift-evolution mailing list<br />
swift-evolution@swift.org<br />
https://lists.swift.org/mailman/listinfo/swift-evolution<br /></blockquote>
</div>
</body>
</html>