<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8">
</head>
<body>
<div style="font-family:sans-serif"><div style="white-space:normal">
<p dir="auto">On 16 Mar 2017, at 15:45, Matthew Johnson wrote:</p>
<p dir="auto"></p></div>
<div style="white-space:normal"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><p dir="auto">> On Mar 16, 2017, at 5:37 PM, Itai Ferber <iferber@apple.com> wrote:</p>
<blockquote style="border-left:2px solid #777; color:#999; margin:0 0 5px; padding-left:5px; border-left-color:#999"><p dir="auto">On 16 Mar 2017, at 14:48, Matthew Johnson wrote:<br>
<br>
Thank you again for bringing these great proposals forward!<br>
<br>
Thanks for reviewing it, and for your comments!<br>
<br>
I only have a couple of questions about this proposal.<br>
<br>
I noticed that the types in this proposal don’t conform to Encoder and Decoder. Is the plan to have them to provide private conforming types to Codable types they are asked to encode or decode?<br>
<br>
Yes. This is because the top-level interface for encoding and decoding in JSON and plist is different from the intermediate interface that Encoder and Decoder offer. As such, the top-level types don’t conform to Encoder and Decoder, but vend out internal types which do.<br>
</p>
</blockquote><p dir="auto">This makes sense. I was initially concerned about the meaning of mutating these values during encoding or decoding but it looks like that isn’t possible without some really nefarious code that passes a reference to the top-level encoder / decoder to an object that is getting encoded / decoded. What will you do if somebody actually does this?</p>
</blockquote></div>
<div style="white-space:normal">
<p dir="auto">The options are copied immutably into the internal types and the originals are not consulted during the process of encoding or decoding — we want to prevent exactly this.<br>
FWIW, you can see the current implementation of this on <a href="https://github.com/apple/swift/pull/8124" style="color:#3983C4">the implementation PR</a>.</p>
<p dir="auto"></p></div>
<div style="white-space:normal"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><blockquote style="border-left:2px solid #777; color:#999; margin:0 0 5px; padding-left:5px; border-left-color:#999"><p dir="auto">Why are the strategy and format properties readwrite instead of configured at initialization time? Is the intent that the encoder / decoder can be re-used with a different configuration in a subsequent call to encode or decode?<br>
<br>
Yes. It’s also a mouthful to have them all as params in the constructor, especially if we add more options in the future.<br>
</p>
</blockquote><p dir="auto">Taking them in an initializer would not need to be wordy - they could all specify default arguments.</p>
</blockquote></div>
<div style="white-space:normal">
<p dir="auto">Sure, but if you want to specify a lot of them…<br>
But, this is more of a stylistic argument. Six of one, half-dozen of another. The more useful thing is supporting mutation after initialization, which is a reasonable thing to want to do.</p>
<p dir="auto"></p></div>
<div style="white-space:normal"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><blockquote style="border-left:2px solid #777; color:#999; margin:0 0 5px; padding-left:5px; border-left-color:#999"><p dir="auto">Finally, I agree with Brent’s comments regarding errors. I would prefer to see Foundation move away from NSError in favor of domain-specific error types. That said, the comment that this is a broader discussion for Foundation and not something to change in this proposal is reasonable. I hope Foundation will consider changing this in the future.<br>
<br>
Thanks for your understanding — we will keep these concerns in mind.<br>
<br>
Matthew<br>
</p>
</blockquote></blockquote></div>
<div style="white-space:normal">
</div>
</div>
</body>
</html>