<div dir="ltr"><div class="gmail_extra"><div><div class="m_-4370145222750863378gmail_signature"><div dir="ltr"><div>On Sat, Feb 18, 2017 at 8:49 PM, Dave Abrahams via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br></div></div></div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div>I'm on vacation and don't have time for a full review right now, but I am concerned that wild this proposal would make enums more <span style="background-color:rgba(255,255,255,0)">general and </span>uniform with the rest of the language , they also would become much more awkward for common use cases. I have recently been very pleased that I didn't have to supply labels in switch statements where the label name would simply have matched the name of the variable to be bound. This looks needlessly verbose:</div><div id="m_-4370145222750863378gmail-m_-7036506994996745938AppleMailSignature"><br></div><div id="m_-4370145222750863378gmail-m_-7036506994996745938AppleMailSignature"> case .valid(value: let value, resumptionPoint: let resumptionPoint):</div><div id="m_-4370145222750863378gmail-m_-7036506994996745938AppleMailSignature"><br></div><div id="m_-4370145222750863378gmail-m_-7036506994996745938AppleMailSignature">I cannot imagine a real life use case where one would have labels in the case and desire to bind associated values to variables having different names than the labels.<br></div></div></blockquote><div><br></div><div>What about something like this? It's a bit contrived, but the point is you could easily expect to work with more than one value of the same enum type at the same time.</div><div><br></div><div><font face="monospace, monospace">enum Color {</font></div><div><font face="monospace, monospace"> case rgb(red: Double, green: Double, blue: Double)</font></div><div><font face="monospace, monospace"> ...</font></div><div><font face="monospace, monospace"><br></font></div><div><font face="monospace, monospace"> func interpolated(to other: Color, by fraction: Double) -> Color {</font></div><div><font face="monospace, monospace"> switch (self, other) {</font></div><div><font face="monospace, monospace"> case (.rgb(red: let red, blue: let blue, green: let green),</font></div><div><font face="monospace, monospace"> .rgb(red: let otherRed, blue: let otherBlue, green: let otherGreen)):</font></div><div><font face="monospace, monospace"> return .rgb(</font></div><div><font face="monospace, monospace"> red: lerp(from: red, to: otherRed, by: fraction),</font></div><div><font face="monospace, monospace"> ...)</font></div><div><font face="monospace, monospace"> ...</font></div><div><font face="monospace, monospace"> }</font></div><div><font face="monospace, monospace"> }</font></div><div><font face="monospace, monospace">}</font></div><div><br></div><div><br></div><div>Your point, though, reminds me of ES6 destructuring assignment, e.g. "let {red, green} = color", and inversely a syntax whose name I don't know, "let color = {red, green}", which are indeed quite convenient when variable names match object key names.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div id="m_-4370145222750863378gmail-m_-7036506994996745938AppleMailSignature">Secondly, I can't imagine a case where one would want to use the same case basename and different labels. The very common use case where the types of associated values completely distinguish the case and one would rather not have to supply a case name at all is completely unaddressed. If my quick read is not mistaken, this proposal makes it legal for cases to have different <i>complete names</i> (including base name and labels), but doesn't make it legal to have the same full name (which I would love to be "_" or missing in some cases) with different associated value types. If we were truly following the precedent set by function signatures, wouldn't that be possible too?</div><div id="m_-4370145222750863378gmail-m_-7036506994996745938AppleMailSignature"></div><div id="m_-4370145222750863378gmail-m_-7036506994996745938AppleMailSignature"><br><div>Sent from my moss-covered three-handled family gradunza</div></div><div><div class="m_-4370145222750863378gmail-h5"><div><br>On Feb 17, 2017, at 5:26 PM, John McCall <<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>> wrote:<br><br></div><blockquote type="cite"><div>Hello Swift community,<br><br>The review of "SE-0155: Normalize Enum Case Representation" begins now and runs through next Friday, February 26th. The proposal is available here:<div><span class="m_-4370145222750863378gmail-m_-7036506994996745938Apple-tab-span" style="white-space:pre-wrap"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0155-normalize-enum-case-representation.md" target="_blank">https://github.com/apple/swift<wbr>-evolution/blob/master/proposa<wbr>ls/0155-normalize-enum-case-<wbr>representation.md</a><div><br></div><div>Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at</div><div><span class="m_-4370145222750863378gmail-m_-7036506994996745938Apple-tab-span" style="white-space:pre-wrap"> </span><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/mailma<wbr>n/listinfo/swift-evolution</a></div><div>or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:</div><div><br><span class="m_-4370145222750863378gmail-m_-7036506994996745938Apple-tab-span" style="white-space:pre-wrap"> </span>Proposal link: <a href="https://github.com/apple/swift-evolution/blob/master/proposals/0155-normalize-enum-case-representation.md" target="_blank">https://github.com/apple<wbr>/swift-evolution/blob/master/<wbr>proposals/0155-normalize-enum-<wbr>case-representation.md</a></div><div><br></div><div><span class="m_-4370145222750863378gmail-m_-7036506994996745938Apple-tab-span" style="white-space:pre-wrap"> </span>Reply text</div><div><br><span class="m_-4370145222750863378gmail-m_-7036506994996745938Apple-tab-span" style="white-space:pre-wrap"> </span>Other replies</div><div><br></div><div><b>What goes into a review?</b><br><br>The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br><br><div><span class="m_-4370145222750863378gmail-m_-7036506994996745938Apple-tab-span" style="white-space:pre-wrap"> </span>• What is your evaluation of the proposal?<br></div><div><span class="m_-4370145222750863378gmail-m_-7036506994996745938Apple-tab-span" style="white-space:pre-wrap"> </span>• Is the problem being addressed significant enough to warrant a change to Swift?<br></div><div><span class="m_-4370145222750863378gmail-m_-7036506994996745938Apple-tab-span" style="white-space:pre-wrap"> </span>• Does this proposal fit well with the feel and direction of Swift?<br></div><div><span class="m_-4370145222750863378gmail-m_-7036506994996745938Apple-tab-span" style="white-space:pre-wrap"> </span>• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></div><div><span class="m_-4370145222750863378gmail-m_-7036506994996745938Apple-tab-span" style="white-space:pre-wrap"> </span>• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br></div><div><br></div>More information about the Swift evolution process is available at <a href="https://github.com/apple/swift-evolution/blob/master/process.md" target="_blank">https://github.com/apple/sw<wbr>ift-evolution/blob/master/proc<wbr>ess.md</a><div><br><div>Thank you,<br><br>John McCall<br>Review Manager</div></div></div></div></div></blockquote></div></div><blockquote type="cite"><div><span>______________________________<wbr>_________________</span><span class="m_-4370145222750863378gmail-"><br><span>swift-evolution-announce mailing list</span><br><span><a href="mailto:swift-evolution-announce@swift.org" target="_blank">swift-evolution-announce@swift<wbr>.org</a></span><br><span><a href="https://lists.swift.org/mailman/listinfo/swift-evolution-announce" target="_blank">https://lists.swift.org/mailma<wbr>n/listinfo/swift-evolution-<wbr>announce</a></span><br></span></div></blockquote></div><br>______________________________<wbr>_________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailma<wbr>n/listinfo/swift-evolution</a><br>
<br></blockquote></div><br></div></div>