<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><blockquote type="cite" class="">What is your evaluation of the proposal?<br class=""></blockquote><div class=""><br class=""></div>+1. I think<div class=""><br class=""></div><div class=""><blockquote type="cite" class="">Is the problem being addressed significant enough to warrant a change to Swift?<br class=""></blockquote><div class=""><br class=""></div>Yes, version pinning is a must-have feature for collaboration in larger scale.</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="">Does this proposal fit well with the feel and direction of Swift?<br class=""></blockquote><div class=""><br class=""></div>Yes, and I admit I like `pinning` (as opposed to `locking` terminology.</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="">If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br class=""></blockquote><div class=""><br class=""></div>Yes - Bundler, Carthage, CocoaPods, Composer. This proposal is very similar to all of above.</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="">How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br class=""></blockquote><div class=""><br class=""></div>Read the proposal and been following the discussions.</div><div class=""><br class=""></div><div class="">–––</div><div class=""><br class=""></div><div class="">I have a little feedback, though:</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class=""><blockquote type="cite" class="">The exact file format is unspecified/implementation defined, however, in practice it will be a JSON data file.<br class=""></blockquote></blockquote><blockquote type="cite" class=""><br class=""></blockquote><blockquote type="cite" class="">Please make it VCS friendly format. If JSON, pretty-print please.<br class=""></blockquote><div class=""><br class=""></div>I agree that pins file should be VCS friendly so that diffs are immediately visible during code review and blame.</div><div class=""><div class="">
<br class="">– Adrian
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">Wiadomość napisana przez Anders Bertelrud via swift-evolution <<a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a>> w dniu 20.11.2016, o godz. 06:48:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><span style="font-family: SFUIText-Regular;" class="">Hello Swift community,</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">The review of "SE-0145: Package Manager Version Pinning" begins again after revisions, starting now and running through November 28th. The proposal is available here:</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0145-package-manager-version-pinning.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0145-package-manager-version-pinning.md</a><div class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-build-dev and swift-evolution mailing lists at</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><a href="https://lists.swift.org/mailman/listinfo/swift-build-dev" style="font-family: SFUIText-Regular;" class="">https://lists.swift.org/mailman/listinfo/swift-build-dev</a><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" style="font-family: SFUIText-Regular;" class="">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">or, if you would like to keep your feedback private, directly to the review manager.</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">What goes into a review?</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><span style="font-family: SFUIText-Regular;" class="">* What is your evaluation of the proposal?</span><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><span style="font-family: SFUIText-Regular;" class="">* Is the problem being addressed significant enough to warrant a change to Swift?</span><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><span style="font-family: SFUIText-Regular;" class="">* Does this proposal fit well with the feel and direction of Swift?</span><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><span style="font-family: SFUIText-Regular;" class="">* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</span><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><span style="font-family: SFUIText-Regular;" class="">* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">More information about the Swift evolution process is available at</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><a href="https://github.com/apple/swift-evolution/blob/master/process.md" style="font-family: SFUIText-Regular;" class="">https://github.com/apple/swift-evolution/blob/master/process.md</a><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">Thank you,</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">Anders Bertelrud</span><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">Review Manager</span><br style="font-family: SFUIText-Regular;" class=""></div></div>_______________________________________________<br class="">swift-evolution mailing list<br class=""><a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-evolution<br class=""></div></blockquote></div><br class=""></div></body></html>