<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Swift community<div class=""><br class=""><blockquote type="cite" class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><span class="" style="font-family: SFUIText-Regular;">* What is your evaluation of the proposal?</span></div></blockquote>The proposal looks good and it solves the addressed problems. Resolving dependency graph is not a trivial problem and I like how this proposal tackles 1 problem at the time.</div><div class=""><br class=""><blockquote type="cite" class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><span class="" style="font-family: SFUIText-Regular;">* Is the problem being addressed significant enough to warrant a change to Swift?</span></div></blockquote>Yes it does. With the "Version Pinning" it would be very convenient to share that information with others</div><div class=""><br class=""><blockquote type="cite" class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><span class="" style="font-family: SFUIText-Regular;"> Does this proposal fit well with the feel and direction of Swift?</span></div></blockquote>Yes it does. </div><div class=""><br class=""></div><div class=""><blockquote type="cite" class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><span class="" style="font-family: SFUIText-Regular;"> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</span></div></blockquote>Some other dependency managers choose to generate pin files by default. I feel it's a correct choice to make "Pin file" optional since SwiftPM requires a versioning tag for a dependency (which is option in others dependency managers I've used)</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><span class="" style="font-family: SFUIText-Regular;">* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</span><br class="" style="font-family: SFUIText-Regular;"></div></blockquote>I tried to study more about dependency pinning and locking, how they are implemented tin other dependency manager and what impact they have.</div><div class=""><br class=""></div><div class="">Additional notes:</div><div class="">When I run <span style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; color: rgb(51, 51, 51); font-size: 13.600000381469727px;" class="">swift package update </span>on unpinned package, would it be possible to roll back to previously used dependencies?</div><div class=""><br class=""></div><div class="">Use case: Let's say I have a package with a dependency A</div><div class=""><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class=""> .</span><span class="pl-c1" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(0, 134, 179);">Package</span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">(</span><span class="pl-c1" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(0, 134, 179);">url</span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">: </span><span class="pl-s" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(24, 54, 145);"><span class="pl-pds" style="box-sizing: border-box;">"</span></span><span style="color: rgb(24, 54, 145); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">https://</span><span class="pl-s" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(24, 54, 145);"><span class="pl-pds" style="box-sizing: border-box;">A</span>.git<span class="pl-pds" style="box-sizing: border-box;">"</span></span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">, </span><span class="pl-c1" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(0, 134, 179);">versions</span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">: </span><span class="pl-c1" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(0, 134, 179);">Version</span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">(</span><span class="pl-c1" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(0, 134, 179);">1</span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">,</span><span class="pl-c1" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(0, 134, 179);">0</span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">,</span><span class="pl-c1" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(0, 134, 179);">0</span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">)</span><span class="pl-k" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(167, 29, 93);">..<</span><span class="pl-c1" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(0, 134, 179);">Version</span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">(</span><span class="pl-c1" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(0, 134, 179);">2</span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">,</span><span class="pl-c1" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(0, 134, 179);">0</span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">,</span><span class="pl-c1" style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247); box-sizing: border-box; color: rgb(0, 134, 179);">0</span><span style="color: rgb(51, 51, 51); font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13.600000381469727px; background-color: rgb(247, 247, 247);" class="">)),</span></div><div class=""><br class=""></div><div class="">At first fetch I get A dependency with v1.0. Then I run `swift package update` and A gets updated to 1.1 </div><div class="">The package is not pinned. If that dependency update break my package is there an easy way for me to roll back?</div><div class=""><br class=""></div><div class=""><div class=""><br class=""><div class="">
<div class="">Best Regards</div><div class="">Kostiantyn</div>
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On 31 Oct 2016, at 22:23, Anders Bertelrud via swift-evolution <<a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><span style="font-family: SFUIText-Regular;" class="">Hello Swift community,</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><font face="SFUIText-Regular" class="">The review of SE-0145 "Package Manager Version Pinning" begins now and runs through November 4. The proposal is available here:</font><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0145-package-manager-version-pinning.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0145-package-manager-version-pinning.md</a><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" style="font-family: SFUIText-Regular;" class="">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">or, if you would like to keep your feedback private, directly to the review manager.</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">What goes into a review?</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><span style="font-family: SFUIText-Regular;" class="">* What is your evaluation of the proposal?</span><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><span style="font-family: SFUIText-Regular;" class="">* Is the problem being addressed significant enough to warrant a change to Swift?</span><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><span style="font-family: SFUIText-Regular;" class="">* Does this proposal fit well with the feel and direction of Swift?</span><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><span style="font-family: SFUIText-Regular;" class="">* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</span><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><span style="font-family: SFUIText-Regular;" class="">* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">More information about the Swift evolution process is available at</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span class="Apple-tab-span" style="font-family: SFUIText-Regular; white-space: pre;"> </span><a href="https://github.com/apple/swift-evolution/blob/master/process.md" style="font-family: SFUIText-Regular;" class="">https://github.com/apple/swift-evolution/blob/master/process.md</a><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">Thank you,</span><br style="font-family: SFUIText-Regular;" class=""><br style="font-family: SFUIText-Regular;" class=""><span style="font-family: SFUIText-Regular;" class="">Anders Bertelrud</span><div class=""><span style="font-family: SFUIText-Regular;" class="">Review Manager</span><br style="font-family: SFUIText-Regular;" class=""></div></div>_______________________________________________<br class="">swift-evolution mailing list<br class=""><a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-evolution<br class=""></div></blockquote></div><br class=""></div></div></body></html>