<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Fri, Oct 14, 2016 at 1:00 PM Chris Lattner via swift-evolution <<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Swift community,<br class="gmail_msg">
<br class="gmail_msg">
The review of "SE-0144: Allow Single Dollar Sign as a Valid Identifier" begins now and runs through October 18. The proposal is available here:<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://github.com/apple/swift-evolution/blob/master/proposals/0144-allow-single-dollar-sign-as-valid-identifier.md" rel="noreferrer" class="gmail_msg" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0144-allow-single-dollar-sign-as-valid-identifier.md</a><br class="gmail_msg">
<br class="gmail_msg">
Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br class="gmail_msg">
<br class="gmail_msg">
or, if you would like to keep your feedback private, directly to the review manager.<br class="gmail_msg">
<br class="gmail_msg">
What goes into a review?<br class="gmail_msg">
<br class="gmail_msg">
The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br class="gmail_msg">
<br class="gmail_msg">
* What is your evaluation of the proposal?<br class="gmail_msg"></blockquote><div><br></div><div>-1. Since the dollar sign is used as a prefix for unnamed closure arguments, allowing it to be used by itself as a user-defined identifier would be odd and potentially confusing. It's also, IMO, a useless standalone identifier because it provides zero self-documentation as to its purpose. Reserving "$" means that users will know that when they see it, it refers to something special and intrinsic to the language.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Is the problem being addressed significant enough to warrant a change to Swift?<br class="gmail_msg"></blockquote><div><br></div><div>No. The library using it is using an undocumented and accidental "feature" that was removed for sound reasons and the language shouldn't change to support that.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Does this proposal fit well with the feel and direction of Swift?<br class="gmail_msg"></blockquote><div><br></div><div>No. The library that is motivating the change is trying to shoehorn Javascript patterns into Swift; the language shouldn't be designed around it. The author's own Cent library, which uses extensions, is a much more Swift-appropriate way to tackle what the problem he's trying to solve.</div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br class="gmail_msg"></blockquote><div><br></div><div>Java and Javascript allow $ as a standalone identifier. I don't see a reason to follow that in Swift, though.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br class="gmail_msg"></blockquote><div><br></div><div>Read the proposal.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg">
More information about the Swift evolution process is available at<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://github.com/apple/swift-evolution/blob/master/process.md" rel="noreferrer" class="gmail_msg" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a><br class="gmail_msg">
<br class="gmail_msg">
Thank you,<br class="gmail_msg">
<br class="gmail_msg">
-Chris Lattner<br class="gmail_msg">
Review Manager<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
swift-evolution mailing list<br class="gmail_msg">
<a href="mailto:swift-evolution@swift.org" class="gmail_msg" target="_blank">swift-evolution@swift.org</a><br class="gmail_msg">
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br class="gmail_msg">
</blockquote></div></div>