<div style="white-space:pre-wrap">(Google inbox won't let me inline my comments)<br><br>Thanks for the effort on iterating and refining this proposal.<br><br>+1 on the proposal, more strongly favoring the first design.<br><br>If my brain is working correctly it seems like we could start with the first design and if somehow problematic move to the the second model in the future without (much?) disruption. I didn't sit down and reason it out in much depth (watching my 2.5 year old at the moment) however so I will leave that to others to ponder.<br><br>I think it aligns well with Swifts principles in terms of favoring external to module API to be intentional / explicit. The latest revisions - I think - has also sufficiently reduced the burden to module developers which is also another important aspect of Swift.<br><br>I haven't used a language the has this exact type of feature but I have often desired to haven his type of capability when I was authoring libraries for others (often in company). I am a believer in being very explicit in API contract to both confine what I have to design for/test when authoring a library as well as having more clarity when consuming a library.</div><div style="white-space:pre-wrap"><br><br><br><br>-Shawn</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 21, 2016 at 11:33 AM Chris Lattner <<a href="mailto:clattner@apple.com" target="_blank">clattner@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Swift community,<br>
<br>
The third review of "SE-0117: Allow distinguishing between public access and public overridability" begins now and runs through July 25. The proposal is available here:<br>
<br>
<a href="https://github.com/apple/swift-evolution/blob/master/proposals/0117-non-public-subclassable-by-default.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0117-non-public-subclassable-by-default.md</a><br>
<br>
Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br>
<br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
<br>
or, if you would like to keep your feedback private, directly to the review manager.<br>
<br>
What goes into a review?<br>
<br>
The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br>
<br>
* What is your evaluation of the proposal?<br>
* Is the problem being addressed significant enough to warrant a change to Swift?<br>
* Does this proposal fit well with the feel and direction of Swift?<br>
* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br>
* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br>
<br>
More information about the Swift evolution process is available at<br>
<br>
<a href="https://github.com/apple/swift-evolution/blob/master/process.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a><br>
<br>
Thank you,<br>
<br>
-Chris Lattner<br>
Review Manager<br>
<br>
<br>
_______________________________________________<br>
swift-evolution-announce mailing list<br>
<a href="mailto:swift-evolution-announce@swift.org" target="_blank">swift-evolution-announce@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution-announce" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution-announce</a><br>
</blockquote></div>