<div dir="ltr">I’ll concur with Jose:<div><br></div><div>Either replace parens with square brackets so the declaration of a subscript matches its point of use (in which case a colon would be acceptable) or else leave it as it is.</div><div><br></div><div>I am (-1) on the proposal as written, (+1) on square brackets for subscripts (with either colon or arrow), and (+0.5) on keeping the status quo.</div><div><br></div><div>Nevin</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 20, 2016 at 1:17 PM, Jose Cheyo Jimenez via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><blockquote type="cite"><span class=""><div>On Jul 20, 2016, at 7:51 AM, Vladimir.S via swift-evolution <<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>> wrote:</div><br></span><span class=""><div><div>+1 to clean up the syntax of subscripts. They acts as properties, not methods, so it is natural to express them with `:` and not with `->`.<br><br>Actually, I'd prefer additional change to use [] instead of () in declaration like:<br><br>subscript[externalName internalName: ParamType] : ElementType {<br> get { … }<br> set { … }<br>}<br></div></div></span></blockquote><div><br></div><div>I got to second this suggestion. To me this is an elegant solution. </div><div><br></div><div>If subscripts are so special that Swift decided to give it its own name (as oppose to just making it two functions), </div><div>why not declare it in a special way like the above?</div><div><br></div><div>I think that in addition to replacing -> with : if we replaced () with [] then it would be much clearer that this is not a function or property. </div><div><br></div><div><span class=""><pre style="font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:13.6px;margin-top:0px;margin-bottom:16px;line-height:1.45;word-wrap:normal;padding:16px;overflow:auto;border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;color:rgb(51,51,51);background-color:rgb(247,247,247)"><code style="font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:13.6px;padding:0px;margin:0px;border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;word-break:normal;border:0px;display:inline;overflow:visible;line-height:inherit;word-wrap:normal;background-color:transparent;background-position:initial initial;background-repeat:initial initial">subscript[externalName internalName: ParamType] : ElementType {
get { … }
set { … }
}</code></pre><div><br></div></span><div>I don’t see another place in the language where [] would make more sense than here: </div><div>Otherwise I don’t see replacing -> with : as a big win like Dmitri Gribenko said down thread -></div><span class=""><div><br></div><div><blockquote type="cite"><blockquote type="cite">I think by changing subscripts to use colons we would end in the opposite, but<br>totally symmetrical situation compared to what we have now.<br></blockquote></blockquote></div><div><br></div></span></div><div> </div><br><blockquote type="cite"><div><div><br><div><div class="h5">especially if thinking about "Future directions" and confusion with parameterised accessor syntax(both declared with `()` but first used with `[]` and second with `()`).<br><br>On 20.07.2016 8:50, Chris Lattner via swift-evolution wrote:<br><blockquote type="cite">Hello Swift community,<br><br>The review of "SE-0122: Use colons for subscript declarations " begins now and runs through July 24. The proposal is available here:<br><br><span style="white-space:pre-wrap"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0122-use-colons-for-subscript-type-declarations.md" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0122-use-colons-for-subscript-type-declarations.md</a><br><br>Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br><br><span style="white-space:pre-wrap"> </span><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br><br>or, if you would like to keep your feedback private, directly to the review manager.<br><br>What goes into a review?<br><br>The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br><br><span style="white-space:pre-wrap"> </span>* What is your evaluation of the proposal?<br><span style="white-space:pre-wrap"> </span>* Is the problem being addressed significant enough to warrant a change to Swift?<br><span style="white-space:pre-wrap"> </span>* Does this proposal fit well with the feel and direction of Swift?<br><span style="white-space:pre-wrap"> </span>* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br><span style="white-space:pre-wrap"> </span>* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br><br>More information about the Swift evolution process is available at<br><br><span style="white-space:pre-wrap"> </span><a href="https://github.com/apple/swift-evolution/blob/master/process.md" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a><br><br>Thank you,<br><br>-Chris Lattner<br>Review Manager<br><br>_______________________________________________<br>swift-evolution mailing list<br><a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br><br></blockquote>_______________________________________________<br>swift-evolution mailing list<br><a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br></div></div></div></div></blockquote></div><br></div><br>_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
<br></blockquote></div><br></div>