<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div><blockquote type="cite" class=""><div class="">On Jul 16, 2016, at 12:59 AM, Xiaodi Wu via swift-evolution <<a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* What is your evaluation of the proposal?<br class=""></blockquote><div class=""><br class=""></div><div class="">This is improved from the previous iteration. The code example needs updating, as both instances of `open func bar()` should be `public open func bar()` as outlined in the Proposed Design section.</div></div></div></div></div></blockquote><div><br class=""></div>Good catch. I'll fix this.</div><div> <br class=""><blockquote type="cite" class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* Does this proposal fit well with the feel and direction of Swift?<br class=""></blockquote><div class=""><br class=""></div><div class="">Yes, mostly. There is one comment in the code example that describes a restriction which does not fit with the direction of Swift. It is not the main focus of the proposal but I think should be changed. Namely, the proposal comments:</div><div class=""><br class=""></div><div class="">"[The declaration `[public] open func bar()` inside a class not marked `open`] raises a compilation error: a method can't be marked `open` if the class it belongs to can't be subclassed."</div><div class=""><br class=""></div><div class="">This is discordant with the direction resolved by the core team in the SE-0025 revisions, where it was stated with regard to access modifiers:</div><div class=""><br class=""></div><div class="">"The compiler should not warn when a broader level of access control is used within a type with more restrictive access, such as `internal` within a `private` type. This allows the owner of the type to design the access they would use were they to make the type more widely accessible."</div><div class=""><br class=""></div><div class="">Applying the same rationale here would suggest that the compiler should not raise an error if a method is marked `open` inside a non-`open` type, in order to allow the owner of the type to design as though to make it subclassable without actually having to do so.</div></div></div></div></blockquote><div><br class=""></div>That's true. We'll consider this.</div><div><br class=""></div><div>John.</div><div><br class=""><blockquote type="cite" class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br class=""></blockquote><div class=""><br class=""></div><div class="">Yes, I've used OOP in other languages. As discussed, this approach is different from that taken by many of those but is a deliberate step.</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br class=""></blockquote><div class=""><br class=""></div><div class="">Followed the discussion, read proposal carefully.</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br class="">
More information about the Swift evolution process is available at<br class="">
<br class="">
<a href="https://github.com/apple/swift-evolution/blob/master/process.md" rel="noreferrer" target="_blank" class="">https://github.com/apple/swift-evolution/blob/master/process.md</a><br class="">
<br class="">
Thank you,<br class="">
<br class="">
-Chris Lattner<br class="">
Review Manager<br class="">
<div class=""><div class="h5"><br class="">
<br class="">
_______________________________________________<br class="">
swift-evolution mailing list<br class="">
<a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a><br class="">
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank" class="">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br class="">
</div></div></blockquote></div><br class=""></div></div>
_______________________________________________<br class="">swift-evolution mailing list<br class=""><a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-evolution<br class=""></blockquote></div><br class=""></body></html>