<div dir="ltr">+1<div><br></div><div>Conditional conformance cannot arrive soon enough.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 12, 2016 at 9:11 PM, Ash Furrow via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><span class=""><div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto"><span style="font-family:'helvetica Neue',helvetica;font-size:14px">* What is your evaluation of the proposal?</span></div><div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto"><br></div></span><div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">+1 from me. I particularly like how this adheres to the principle of least surprise. Keeping == and != is an important part of the proposal, as others have said.</div><span class=""><div style="color:rgb(0,0,0);margin:0px"><br><span style="font-family:'helvetica Neue',helvetica;font-size:14px">* Is the problem being addressed significant enough to warrant a change to Swift?</span></div><div style="color:rgb(0,0,0);margin:0px"><br></div></span><div style="color:rgb(0,0,0);margin:0px">I believe so. </div><span class=""><div style="color:rgb(0,0,0);margin:0px"><br style="font-family:'helvetica Neue',helvetica;font-size:14px"><span style="font-family:'helvetica Neue',helvetica;font-size:14px">* Does this proposal fit well with the feel and direction of Swift?</span></div><div style="color:rgb(0,0,0);margin:0px"><br></div></span><div style="color:rgb(0,0,0);margin:0px">Aye, pretty happy about its direction.</div><span class=""><div style="color:rgb(0,0,0);margin:0px"><br style="font-family:'helvetica Neue',helvetica;font-size:14px"><span style="font-family:'helvetica Neue',helvetica;font-size:14px">* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</span></div><div style="color:rgb(0,0,0);margin:0px"><br></div></span><div style="color:rgb(0,0,0);margin:0px">I have: Objective-C! Converting the code from the proposal, we have:</div><div style="color:rgb(0,0,0);margin:0px"><br></div><div style="color:rgb(0,0,0);margin:0px">NSArray *ps = [peeps filter:^BOOL(Person *lhs, Person *rhs) { </div><div style="color:rgb(0,0,0);margin:0px"> return [[lhs pet] age] < [[rhs pet] age]; </div><div style="color:rgb(0,0,0);margin:0px">}];</div><div style="color:rgb(0,0,0);margin:0px"><br></div><div style="color:rgb(0,0,0);margin:0px">I think that convention works in Objective-C, nil being capable of receiving messages is a cornerstone of the language. But Swift has discouraged the convention of calling functions directly on nil, through Optionals. I believe that removing the comparison operators for Optionals adheres to the same ideas that Optionals themselves are built from.</div><span class=""><div style="color:rgb(0,0,0);margin:0px"><br style="font-family:'helvetica Neue',helvetica;font-size:14px"><span style="font-family:'helvetica Neue',helvetica;font-size:14px">* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</span></div><div style="color:rgb(0,0,0);margin:0px"><span style="font-family:'helvetica Neue',helvetica;font-size:14px"><br></span></div></span><div style="margin:0px"><font face="helvetica Neue, helvetica"><span style="font-size:14px">I read the review thoroughly, asked on Twitter, let it sit in the back of my head for an hour. I also had to spend five minutes figuring out the </span></font>Objective-C block syntax for a filter function.</div><span class="HOEnZb"><font color="#888888"> <br> <div><div style="font-family:helvetica,arial;font-size:13px">-- <br>Ash Furrow<br><a href="https://ashfurrow.com/" target="_blank">https://ashfurrow.com/</a></div></div></font></span><span class=""> <br><p>On July 12, 2016 at 2:26:55 PM, Chris Lattner via swift-evolution (<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>) wrote:</p> </span><blockquote type="cite"><span><div><div></div><div><span class="">Hello Swift community,<br><br>The review of "SE-0121: Remove `Optional` Comparison Operators" begins now and runs through July 19. The proposal is available here:<br><br> <a href="https://github.com/apple/swift-evolution/blob/master/proposals/0121-remove-optional-comparison-operators.md" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0121-remove-optional-comparison-operators.md</a><br><br>Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br><br> <a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br><br>or, if you would like to keep your feedback private, directly to the review manager.<br><br>What goes into a review?<br><br>The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br><br> * What is your evaluation of the proposal?<br> * Is the problem being addressed significant enough to warrant a change to Swift?<br> * Does this proposal fit well with the feel and direction of Swift?<br> * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br> * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br><br>More information about the Swift evolution process is available at<br><br> <a href="https://github.com/apple/swift-evolution/blob/master/process.md" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a><br><br>Thank you,<br><br>-Chris Lattner<br>Review Manager<br><br>_______________________________________________<br></span><span class="">swift-evolution mailing list<br><a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br></span></div></div></span></blockquote></div><br>_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
<br></blockquote></div><br></div>