<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Proposal link:<br>
<a href="https://github.com/apple/swift-evolution/blob/master/proposals/0120-revise-partition-method.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0120-revise-partition-method.md</a><br><br>
* What is your evaluation of the proposal?<br></blockquote><div><br></div><div>+1, although I don't think the functions should be marked with @discardableResult. The partition method is hardly useful if you don't know where the partition index is.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Is the problem being addressed significant enough to warrant a change to Swift?<br></blockquote><div><br></div><div>Somewhat. This API isn't commonly used (I've never used it), but APIs in the standard library deserve to make sense and be useful :-)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Does this proposal fit well with the feel and direction of Swift?<br></blockquote><div><br></div><div>Yes, the new API seems to feel "Swifty", and conform to the API design guidelines.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></blockquote><div> </div><div>N/A</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</blockquote><div> </div><div>Brief reading of the proposal and a look at the existing API. I've never used this API in Swift.</div><div><br></div></div></div></div>