<div dir="ltr">+1. I'd prefer the "open" keyword though, and use it as a modifier of public.<br></div><br><div class="gmail_quote"><div dir="ltr">El mié., 6 jul. 2016 a las 1:24, Charlie Monroe via swift-evolution (<<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a>>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Huge +1.<br>
<br>
Question about inheritance though:<br>
<br>
class A {} // Not publicly subclassable<br>
subclassable class B: A {} // Publicly subclassable<br>
class C: B {} // Not publicly subclassable? Or is the subclassability inherited?<br>
<br>
I'm not a big fan of the subclassable keyword either since it's quite long, not to mention it contains "class" which is the next keyword, making it visually repetitive.<br>
<br>
I'd prefer open on both class and func to introduce only one keyword instead of two and possibly make it as a modifier of public to keep it in line with private(set)...<br>
<br>
> On Jul 6, 2016, at 1:11 AM, Chris Lattner via swift-evolution <<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>> wrote:<br>
><br>
> Hello Swift community,<br>
><br>
> The review of "SE-0117: Default classes to be non-subclassable publicly" begins now and runs through July 11. The proposal is available here:<br>
><br>
> <a href="https://github.com/apple/swift-evolution/blob/master/proposals/0117-non-public-subclassable-by-default.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0117-non-public-subclassable-by-default.md</a><br>
><br>
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br>
><br>
> <a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
><br>
> or, if you would like to keep your feedback private, directly to the review manager.<br>
><br>
> What goes into a review?<br>
><br>
> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br>
><br>
> * What is your evaluation of the proposal?<br>
> * Is the problem being addressed significant enough to warrant a change to Swift?<br>
> * Does this proposal fit well with the feel and direction of Swift?<br>
> * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br>
> * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br>
><br>
> More information about the Swift evolution process is available at<br>
><br>
> <a href="https://github.com/apple/swift-evolution/blob/master/process.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a><br>
><br>
> Thank you,<br>
><br>
> -Chris Lattner<br>
> Review Manager<br>
><br>
> _______________________________________________<br>
> swift-evolution mailing list<br>
> <a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br>
> <a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
<br>
_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
</blockquote></div>