<div dir="ltr"><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"> What is your evaluation of the proposal?<br></blockquote><div>+1<br><br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">Is the problem being addressed significant enough to warrant a change to Swift?<br></blockquote><div>Yes. Passing value types to Objective-C APIs taking AnyObject requires creating wrapper classes that store the value types. This change would eliminate that workaround and allow for more flexible and idiomatic code when using Cocoa APIs.<br><br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">Does this proposal fit well with the feel and direction of Swift?<br></blockquote><div>Yes, now that certain Objective-C types are bridgeable to Swift as value types, this feels like a natural next step.<br></div><div> </div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</blockquote><div>Quick reading. <br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 5, 2016 at 10:45 AM, Charlie Monroe via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class=""><br>
> On Jul 5, 2016, at 6:37 PM, Joe Groff <<a href="mailto:jgroff@apple.com">jgroff@apple.com</a>> wrote:<br>
><br>
>><br>
>> On Jul 5, 2016, at 9:06 AM, Charlie Monroe via swift-evolution <<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a>> wrote:<br>
>><br>
>> +1, but I'm not a big fan of the proposed Optional -> NSNull bridging which can cause various hard-to-debug issues with errors "NSNull doesn't respond to a selector -foo".<br>
><br>
> I'm not proposing that particular mapping as part of this proposal, only as a potential future direction. However, these issues should be avoided by dynamic casting type checks. An untyped NSArray that contains NSNulls would come into Swift as an [Any], and would fail to dynamically cast to [Foo]. You'd have to cast it to [Foo?], which would force you to handle the NSNulls as Swift nils.<br>
<br>
</span>Ok, though my bigger concern was the other way around - passing accidently array of [Foo?] to an ObjC class that takes id as an argument.<br>
<br>
But other than this, the proposal will make the code Swiftier and it is definitely the correct direction for Swift in general!<br>
<div class=""><div class="h5"><br>
><br>
> -Joe<br>
><br>
>><br>
>> Most APIs that take "id" as an argument usually specify several types that the API accepts (e.g. arrays and dictionaries), but passing in NSNull is not acceptable. I believe this change would create confusion rather than eliminate it as is the goal of this proposal.<br>
>><br>
>>> On Jul 5, 2016, at 5:45 PM, Chris Lattner via swift-evolution <<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a>> wrote:<br>
>>><br>
>>> Hello Swift community,<br>
>>><br>
>>> The review of "SE-0116: Import Objective-C id as Swift Any type" begins now and runs through July 11. The proposal is available here:<br>
>>><br>
>>> <a href="https://github.com/apple/swift-evolution/blob/master/proposals/0116-id-as-any.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0116-id-as-any.md</a><br>
>>><br>
>>> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br>
>>><br>
>>> <a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
>>><br>
>>> or, if you would like to keep your feedback private, directly to the review manager.<br>
>>><br>
>>> What goes into a review?<br>
>>><br>
>>> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br>
>>><br>
>>> * What is your evaluation of the proposal?<br>
>>> * Is the problem being addressed significant enough to warrant a change to Swift?<br>
>>> * Does this proposal fit well with the feel and direction of Swift?<br>
>>> * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br>
>>> * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br>
>>><br>
>>> More information about the Swift evolution process is available at<br>
>>><br>
>>> <a href="https://github.com/apple/swift-evolution/blob/master/process.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a><br>
>>><br>
>>> Thank you,<br>
>>><br>
>>> -Chris Lattner<br>
>>> Review Manager<br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> swift-evolution mailing list<br>
>>> <a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
>>> <a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
>><br>
>> _______________________________________________<br>
>> swift-evolution mailing list<br>
>> <a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
>> <a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
<br>
_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
</div></div></blockquote></div><br></div></div>