<div dir="ltr"><div><b>* What is your evaluation of the proposal?</b></div><div><br></div><div>-1</div><div><br></div><div>I find myself using 3 types of closures:</div><div> - Algorithm-like (filter, map etc.). non-escaping</div><div> - Completion closures: asynchronous operations: network requests, many cocoa APIs, background image processing. escaping</div><div> - Data/dependency providers: userProvider(forId id: String) -> User. escaping (ok, can be non-escaping sometimes too)</div><div><br></div><div>In the codebases I'm working with, escaping closures predominate clearly; and most of the non-escaping ones refer to usages of the standard library.</div><div><br></div><div>Another point comes when changing things. Consider the following code:</div><div><br></div><div>func doSomething(closure: () -> Void) {</div><div><span class="" style="white-space:pre"> </span>self.doSomething2(closure)</div><div>}</div><div><br></div><div>func doSomething2(closure: () -> Void) {</div><div><span class="" style="white-space:pre"> </span>self.doSomething3(closure)</div><div>}</div><div><br></div><div>func doSomething3(closure: () -> Void) {</div><div><span class="" style="white-space:pre"> </span>closure()</div><div>}</div><div><br></div><div>If non-escaping is the default, and for some reason doSomething3's closure needs to change to escaping, then I would have to change all the callers as escaping.</div><div><br></div><div>To sump up, I see @noescape as something to opt-in for performance reasons (or better static analysis as it was mentioned during the initial discussion) but I don't think it's a good default.</div><div><br></div><div><b>* Is the problem being addressed significant enough to warrant a change to Swift?</b></div><div>I don't think there's a problem that needs to be fixed.</div><div><br></div><div><b>* Does this proposal fit well with the feel and direction of Swift?</b></div><div>Not really. I think escaping is a safe good default that works for all cases.</div><div><br></div><div><b>* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</b></div><div>NA</div><div><br></div><div><b>* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</b></div><div>Followed the discussion and read the proposal carefully.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-06-22 6:03 GMT+01:00 Chris Lattner via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Swift community,<br>
<br>
The review of "SE-0103: Make non-escaping closures the default" begins now and runs through June 27. The proposal is available here:<br>
<br>
<a href="https://github.com/apple/swift-evolution/blob/master/proposals/0103-make-noescape-default.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0103-make-noescape-default.md</a><br>
<br>
Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br>
<br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
<br>
or, if you would like to keep your feedback private, directly to the review manager.<br>
<br>
What goes into a review?<br>
<br>
The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br>
<br>
* What is your evaluation of the proposal?<br>
* Is the problem being addressed significant enough to warrant a change to Swift?<br>
* Does this proposal fit well with the feel and direction of Swift?<br>
* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br>
* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br>
<br>
More information about the Swift evolution process is available at<br>
<br>
<a href="https://github.com/apple/swift-evolution/blob/master/process.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a><br>
<br>
Thank you,<br>
<br>
-Chris Lattner<br>
Review Manager<br>
<br>
<br>
_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
</blockquote></div><br></div>