<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jun 23, 2016 at 1:56 PM, Max Moiseev <span dir="ltr">&lt;<a href="mailto:moiseev@apple.com" target="_blank">moiseev@apple.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>Hi Xiaodi,</div><span class=""><div><br></div><div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Q2: I do not understand the comment explaining signBitIndex. I thought I understood what it does from the name, but the comment says it&#39;s not the right name. So what is signBitIndex?</div></div></div></div></blockquote></div></span><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>The name is good but the way it is implemented in the prototype currently is NOT what the name suggests. This is the point of the comment. I plan to revisit the prototype and either make it behave the way it’s called, or find a better name for what it currently does.</div><div><br></div><div><span class=""><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Ask: You&#39;ve got bitWidth and nthWord. Any way you could expose __builtin_popcount()? Pretty please?</div></div></div></div></blockquote></span>I don’t mind adding it to the concrete types, similar to `countLeadingZeros` (see <a href="https://github.com/apple/swift/blob/master/test/Prototypes/Integers.swift.gyb#L855" target="_blank">https://github.com/apple/swift/blob/master/test/Prototypes/Integers.swift.gyb#L855</a>). Do you think it should be a protocol requirement instead?</div></div></div></div></div></div></blockquote><div><br></div><div>You&#39;re right, probably best belongs on concrete types.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="HOEnZb"><font color="#888888"><div><br></div><div><br></div><div>Max</div></font></span></div></div></div></div><div><div class="h5"><div><br></div><br><div><blockquote type="cite"><div>On Jun 22, 2016, at 6:13 PM, Xiaodi Wu via swift-evolution &lt;<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>&gt; wrote:</div><br><div><div dir="ltr" style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jun 22, 2016 at 7:52 PM, Chris Lattner via swift-evolution<span> </span><span dir="ltr">&lt;<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>&gt;</span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hello Swift community,<br><br>The review of &quot;SE-0104: Protocol-oriented integers&quot; begins now and runs through June 27. The proposal is available here:<br><br>       <span> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0104-improved-integers.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0104-improved-integers.md</a><br><br>Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br><br>       <span> </span><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br><br>or, if you would like to keep your feedback private, directly to the review manager.<br><br>What goes into a review?<br><br>The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br><br>       <span> </span>* What is your evaluation of the proposal?<br></blockquote><div><br></div><div>This is excellent, and a huge improvement. Two questions and one ask:</div><div><br></div><div>Q1: With the adoption of this proposal, will FloatingPoint conform to Arithmetic?</div><div>Q2: I do not understand the comment explaining signBitIndex. I thought I understood what it does from the name, but the comment says it&#39;s not the right name. So what is signBitIndex?</div><div>Ask: You&#39;ve got bitWidth and nthWord. Any way you could expose __builtin_popcount()? Pretty please?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">       <span> </span>* Is the problem being addressed significant enough to warrant a change to Swift?<br></blockquote><div><br></div><div>Yes, the current tangle of protocols is not exactly fun to work with for generics.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">       <span> </span>* Does this proposal fit well with the feel and direction of Swift?<br></blockquote><div><br></div><div>Yes.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">       <span> </span>* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></blockquote><div><br></div><div>Not applicable, I think.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">       <span> </span>* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br></blockquote><div><br></div><div>Read the proposal, worked with the existing protocols, thought carefully about numbers in the context of the FloatingPoint discussion.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>More information about the Swift evolution process is available at<br><br>       <span> </span><a href="https://github.com/apple/swift-evolution/blob/master/process.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a><br><br>Thank you,<br><br>-Chris Lattner<br>Review Manager<br><br><br>_______________________________________________<br>swift-evolution mailing list<br><a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br></blockquote></div><br></div></div><span style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">_______________________________________________</span><br style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">swift-evolution mailing list</span><br style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="mailto:swift-evolution@swift.org" style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">swift-evolution@swift.org</a><br style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a></div></blockquote></div><br></div></div></div></blockquote></div><br></div></div>