<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hey, standard library folks. Glad we're doing this one. :-)<div class=""><br class=""></div><div class="">- I remain unconvinced that defining an Arithmetic that includes both exact and floating-point numbers is a good idea. All of the arguments from Swift 1 and 2 about why we didn't include this still seem relevant. To phrase it in generic programming terms, what algorithm would be generic over Arithmetic?</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">- What is Integer.init<T: FloatingPoint>(_:) supposed to do if the floating-point value is larger than the maximum representable integer? Smaller than the minimum? (As a special case, negative, when the integer type is unsigned?) Infinity? NaN?</div><div class=""><br class=""></div><div class="">- Integer.init<T: Integer>(_:) currently says "if it is representable". It should say something like "trapping if it is not representable".</div><div class=""><br class=""></div><div class="">- I find it odd that Integer.init(clamping:) privileges the bounds of fixed-width integers. I was going to suggest it should take a range to clamp to that <i class="">defaults</i> to the min and max, but that's not implementable for a BigInt.</div><div class=""><br class=""></div><div class="">- nthWord should count "from least-significant to most-significant" rather than "from the right".</div><div class=""><br class=""></div><div class="">- As mentioned before, it sounds like Integer requires a two's complement representation (if only so the result of nthWord can be interpreted correctly). That should probably be in the doc comment for the protocol.</div><div class=""><br class=""></div><div class="">- Why is bitWidth in bits but nthWord in words? (I know there's a good answer to this, but using them together seems like it will be common.)</div><div class=""><br class=""></div><div class="">- It's also probably worth calling out <i class="">even more explicitly</i> that bitWidth is a <i class="">representation</i> property, not a <i class="">value</i> property. That is, a BigInt with the value "1" could have a bitWidth of 1, 8, or 128.</div><div class=""><br class=""></div><div class="">- What does signBitIndex return if self is positive? I ask because it's just not in the doc comment, but thinking about the answer made it obvious that the correct return value for 0 is 0.</div><div class=""><br class=""></div><div class="">- For signed integers, does remainder(dividingBy:) have specified behavior for the sign of the result? See <a href="https://en.wikipedia.org/wiki/Modulo_operation" class="">https://en.wikipedia.org/wiki/Modulo_operation</a>.</div><div class=""><br class=""></div><div class=""><div class="">- I do think having Swift.abs(_:) and Integer.absoluteValue is confusing, but I don't know what to do about it.</div></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">- Why are bitwise operations limited to fixed-width integers? I see "The only difference is that because shifting left truncates the high bits of fixed-width integers, it is hard to define what a left shift would mean to an arbitrary-precision integer" further down, but I would just assume it wouldn't truncate (i.e. it would be a pure multiplication by two).</div><div class=""><br class=""></div><div class="">- Is there a requirement about left-shifting into the sign bit, for '<<' and for '&<<'?</div><div class=""><div class=""><br class=""></div><div class="">- What is the ArithmeticOverflow type?</div><div class=""><br class=""></div><div class="">- When does the remainder operation overflow? (I just can't remember.)</div><div class=""><br class=""></div><div class="">- I feel a little weird having "someValue.and(mask)". Maybe bitwiseAnd or bitwiseAND to be more explicit?</div><div class=""><br class=""></div></div><div class="">- maskingShiftLeft/Right seem underspecified in their doc comments. Why can't the protocol requirement just assume the shift amount has already been masked, instead of performing the masking themselves? Is it because we won't be able to optimize that away?</div><div class=""><br class=""></div><div class="">I think that's about it. Great work, all!</div><div class="">Jordan</div></body></html>