<div dir="ltr">Karl - Absolute value of `Int.min` is currently not representable by an Int. </div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 22, 2016 at 9:32 PM, Karl via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1<br>
<br>
Looks very good. A couple of points:<br>
<br>
- I’m not convinced about ‘absoluteValue’, with an associated type. I think it should return the same value as ‘abs()’ or have a different name if it’s really needed at all; the example of a print function is a bit weak IMO.<br>
- I’m not sure about an ‘nthWord()’ getter without a corresponding setter.<br>
- I would like ‘floor’ and ‘ceil’ to be part of the standard library (or some equivalent). It annoys me that I have to import Darwin/Glibc to properly convert between standard library types. Would this go with the initialisers from FloatingPoint on Integer, or somewhere on FloatingPoint?<br>
<br>
Definitely a step up from what we have, and a good foundation to build on.<br>
<br>
Karl<br>
<div class="HOEnZb"><div class="h5"><br>
> On 23 Jun 2016, at 02:52, Chris Lattner via swift-evolution <<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a>> wrote:<br>
><br>
> Hello Swift community,<br>
><br>
> The review of "SE-0104: Protocol-oriented integers" begins now and runs through June 27. The proposal is available here:<br>
><br>
> <a href="https://github.com/apple/swift-evolution/blob/master/proposals/0104-improved-integers.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0104-improved-integers.md</a><br>
><br>
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br>
><br>
> <a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
><br>
> or, if you would like to keep your feedback private, directly to the review manager.<br>
><br>
> What goes into a review?<br>
><br>
> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br>
><br>
> * What is your evaluation of the proposal?<br>
> * Is the problem being addressed significant enough to warrant a change to Swift?<br>
> * Does this proposal fit well with the feel and direction of Swift?<br>
> * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br>
> * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br>
><br>
> More information about the Swift evolution process is available at<br>
><br>
> <a href="https://github.com/apple/swift-evolution/blob/master/process.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a><br>
><br>
> Thank you,<br>
><br>
> -Chris Lattner<br>
> Review Manager<br>
><br>
><br>
> _______________________________________________<br>
> swift-evolution mailing list<br>
> <a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
> <a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
<br>
_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
</div></div></blockquote></div><br></div>