<div dir="ltr"><span style="font-size:13px"> * What is your evaluation of the proposal?</span><div>+1. I've used unfold/iterate functions in Haskell and Clojure, and they are very useful.<br style="font-size:13px"><span style="font-size:13px"> * Is the problem being addressed significant enough to warrant a change to Swift?</span></div><div>Yes.<br style="font-size:13px"><span style="font-size:13px"> * Does this proposal fit well with the feel and direction of Swift?</span></div><div>Yes.<br style="font-size:13px"><span style="font-size:13px"> * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</span></div><div>See above.<br style="font-size:13px"><span style="font-size:13px"> * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</span><br></div><div><span style="font-size:13px">Quick reading.</span></div><div><span style="font-size:13px"><br></span></div><div>Also note that there's a typo in the second example:</div><div><br></div><div><pre style="font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:14px;margin-top:0px;margin-bottom:0px;line-height:1.45;word-wrap:normal;padding:16px;overflow:auto;background-color:rgb(247,247,247);border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;color:rgb(51,51,51)"><span class="" style="color:rgb(167,29,93)">for</span> view <span class="" style="color:rgb(167,29,93)">in</span> sequence(initial: someView, next: { $<span class="" style="color:rgb(0,134,179)">0</span><span class="" style="color:rgb(167,29,93)">.</span>superview }) {
<span class="" style="color:rgb(150,152,150)">// someView, someView.superview, someView.superview.superview, ...</span>
}</pre></div><div><br></div><div>should be:</div><div><br></div><div><pre style="font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:14px;margin-top:0px;margin-bottom:0px;line-height:1.45;word-wrap:normal;padding:16px;overflow:auto;background-color:rgb(247,247,247);border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;color:rgb(51,51,51)"><span class="" style="color:rgb(167,29,93)">for</span> view <span class="" style="color:rgb(167,29,93)">in</span> sequence(state: someView, next: { $<span class="" style="color:rgb(0,134,179)">0</span><span class="" style="color:rgb(167,29,93)">.</span>superview }) {
<span class="" style="color:rgb(150,152,150)">// someView, someView.superview, someView.superview.superview, ...</span>
}</pre></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 19, 2016 at 6:29 PM, Chris Lattner via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Swift community,<br>
<br>
The review of "SE-0094: Add sequence(initial:next:) and sequence(state:next:) to the stdlib" begins now and runs through May 23. This is a refinement of part of SE-0045. The proposal is available here:<br>
<br>
<a href="https://github.com/apple/swift-evolution/blob/master/proposals/0094-sequence-function.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/proposals/0094-sequence-function.md</a><br>
<br>
Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br>
<br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
<br>
or, if you would like to keep your feedback private, directly to the review manager.<br>
<br>
What goes into a review?<br>
<br>
The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br>
<br>
* What is your evaluation of the proposal?<br>
* Is the problem being addressed significant enough to warrant a change to Swift?<br>
* Does this proposal fit well with the feel and direction of Swift?<br>
* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br>
* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br>
<br>
More information about the Swift evolution process is available at<br>
<br>
<a href="https://github.com/apple/swift-evolution/blob/master/process.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a><br>
<br>
Thank you,<br>
<br>
-Chris Lattner<br>
Review Manager<br>
_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Trent Nadeau</div>
</div>