<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* What is your evaluation of the proposal?<br></blockquote><div><br></div><div>Generally in favor. To indulge in a little bikeshedding:</div><div><br></div><div>* `precedencegroup` defines both associativity and precedence, so the naming isn't great. Maybe `operatorgroup`?</div><div>* I'm not sure about the parentheses used between the braces. To me, it would fit better with the language to use colons.</div><div>* It may be confusing that relative precedence levels are themselves described using operators or words that describe operators. I'd suggest simpler words that aren't self-referential, such as "above" and "below".</div><div><br></div><div>So to put it all together, here's the color of my bikeshed:</div><div><br></div><div>```</div><div>operatorgroup Comparative {</div><div> associativity: left,</div><div> precedence: above(LogicalAnd)</div><div>}</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Is the problem being addressed significant enough to warrant a change to Swift?<br>
* Does this proposal fit well with the feel and direction of Swift?<br>
* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br>
* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br>
<br>
More information about the Swift evolution process is available at<br>
<br>
<a href="https://github.com/apple/swift-evolution/blob/master/process.md" rel="noreferrer" target="_blank">https://github.com/apple/swift-evolution/blob/master/process.md</a><br>
<br>
Thank you,<br>
<br>
-Chris Lattner<br>
Review Manager<br>
<br>
<br>
<br>
_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
</blockquote></div><br></div></div>