<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><span class="">1. What is your evaluation of the proposal?</span><div class=""><span class="">+1 I think this is a big win for readability.</span></div><div class=""><span class=""><br class=""></span></div><div class=""><span class="">2. Is the problem being addressed significant enough to warrant a change to Swift?<br class=""></span></div><div class=""><span class="">Yes. dispatch is used nearly everywhere so many many projects would benefit from it.</span></div><div class=""><span class=""><br class=""></span></div><div class=""><span class="">3. Does this proposal fit well with the feel and direction of Swift?<br class=""></span></div><div class=""><span class="">Making the API more “swift" and feel more natural definitely is the direction Swift libraries are / should be going in.</span></div><div class=""><span class=""><br class=""></span></div><div class=""><span class="">4. If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br class=""></span></div><div class=""><span class="">Unfortunately not.</span></div><div class=""><span class=""><br class=""></span></div><div class=""><span class="">5. How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</span></div><div class="">Read the proposal twice.</div><div class=""><br class=""></div><div class="">A little nitpick:</div><div class=""><br class=""></div><div class=""><pre style="box-sizing: border-box; font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 14px; margin-top: 0px; margin-bottom: 0px; line-height: 1.45; padding: 16px; overflow: auto; background-color: rgb(247, 247, 247); border-top-left-radius: 3px; border-top-right-radius: 3px; border-bottom-right-radius: 3px; border-bottom-left-radius: 3px; word-wrap: normal; word-break: normal; color: rgb(51, 51, 51);" class=""><span class="pl-k" style="box-sizing: border-box; color: rgb(167, 29, 93);">let</span> item <span class="pl-k" style="box-sizing: border-box; color: rgb(167, 29, 93);">=</span> DispatchWorkItem(qos: <span class="pl-k" style="box-sizing: border-box; color: rgb(167, 29, 93);">.</span>qosUserInitiated) {
<span class="pl-c1" style="box-sizing: border-box; color: rgb(0, 134, 179);">print</span>(<span class="pl-s" style="box-sizing: border-box; color: rgb(24, 54, 145);"><span class="pl-pds" style="box-sizing: border-box;">"</span>Hello World<span class="pl-pds" style="box-sizing: border-box;">"</span></span>)
}
</pre><div class=""><br class=""></div></div><div class=""><span class="">I’d change the enum case from .qosUserInitiated to .userInitiated (maybe that’s just a typo since in the code example before uses </span>.unspecified).</div><div class=""><span class=""><br class=""></span></div><div class=""><span class="">- Dennis</span></div>
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On May 11, 2016, at 6:39 AM, Chris Lattner <<a href="mailto:clattner@apple.com" class="">clattner@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hello Swift community,<br class=""><br class="">The review of "SE-0088: Modernize libdispatch for Swift 3 naming conventions" begins now and runs through May 17. The proposal is available here:<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0088-libdispatch-for-swift3.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0088-libdispatch-for-swift3.md</a><br class=""><br class="">Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>https://lists.swift.org/mailman/listinfo/swift-evolution<br class=""><br class="">or, if you would like to keep your feedback private, directly to the review manager.<br class=""><br class="">What goes into a review?<br class=""><br class="">The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>* What is your evaluation of the proposal?<br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>* Is the problem being addressed significant enough to warrant a change to Swift?<br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>* Does this proposal fit well with the feel and direction of Swift?<br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br class=""><br class="">More information about the Swift evolution process is available at<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>https://github.com/apple/swift-evolution/blob/master/process.md<br class=""><br class="">Thank you,<br class=""><br class="">-Chris Lattner<br class="">Review Manager<br class=""><br class=""><br class=""><br class="">_______________________________________________<br class="">swift-evolution-announce mailing list<br class="">swift-evolution-announce@swift.org<br class="">https://lists.swift.org/mailman/listinfo/swift-evolution-announce<br class=""></div></div></blockquote></div><br class=""></body></html>