<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">My main piece of feedback is that the method names synchronously() and asynchronously() don’t conform to Swift 3 naming conventions for functions and methods:<div class=""><br class=""></div><div class=""><i class="">"Name functions and methods according to their side-effects<br class=""><br class=""></i><div class=""><i class=""><span class="Apple-tab-span" style="white-space:pre"> </span>• Those without side-effects should read as noun phrases, e.g. x.distance(to: y), i.successor().<br class=""><br class=""></i></div><div class=""><i class=""><span class="Apple-tab-span" style="white-space:pre"> </span>• Those with side-effects should read as imperative verb phrases, e.g., print(x), x.sort(), x.append(y).”</i></div><div class=""><br class=""></div><div class="">The method names</div><div class=""><br class=""></div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>synchronously()</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>asynchronously() </div><div class=""><br class=""></div><div class="">are both adverbs, not noun phrases or verb phrases.</div><div class="">These methods have side effects, so each name should have a verb in it to make it a verb phrase.</div><div class=""><br class=""></div><br class=""><div class=""><div class="">Since these are the methods where you actually dispatch a block into a queue</div><div class=""><br class=""></div><div class="">dispatchSynchronously()</div><div class="">dispatchAsynchronously()</div><div class=""><br class=""></div><div class="">would include the verb in the name of the methods.</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Since the majority of uses of GCD is for async dispatch, you could possibly make async the ‘default' and have the two names be:</div><div class=""><br class=""></div><div class="">dispatch() // Dispatches Asynchronously</div><div class="">dispatchSynchronously()</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><div class="">You could potentially make the case that ’sync’ and ‘async’ are well-known terms in their own right, not just abbreviations, and use them instead of the longer words:</div><div class=""><br class=""></div><div class="">dispatchAsynch()</div><div class="">dispatchSynch()</div></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">James</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 10, 2016, at 9:39 PM, Chris Lattner via swift-evolution <<a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hello Swift community,<br class=""><br class="">The review of "SE-0088: Modernize libdispatch for Swift 3 naming conventions" begins now and runs through May 17. The proposal is available here:<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0088-libdispatch-for-swift3.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0088-libdispatch-for-swift3.md</a><br class=""><br class="">Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>https://lists.swift.org/mailman/listinfo/swift-evolution<br class=""><br class="">or, if you would like to keep your feedback private, directly to the review manager.<br class=""><br class="">What goes into a review?<br class=""><br class="">The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>* What is your evaluation of the proposal?<br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>* Is the problem being addressed significant enough to warrant a change to Swift?<br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>* Does this proposal fit well with the feel and direction of Swift?<br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br class=""><br class="">More information about the Swift evolution process is available at<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>https://github.com/apple/swift-evolution/blob/master/process.md<br class=""><br class="">Thank you,<br class=""><br class="">-Chris Lattner<br class="">Review Manager<br class=""><br class=""><br class=""><br class="">_______________________________________________<br class="">swift-evolution mailing list<br class="">swift-evolution@swift.org<br class="">https://lists.swift.org/mailman/listinfo/swift-evolution<br class=""></div></div></blockquote></div><br class=""></div></div></div></body></html>