<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* What is your evaluation of the proposal?<br></blockquote><div><br></div><div>+1. These are self-evidently useful functions.</div><div><br></div><div>One issue: not sure I understand why the "customization points" are necessary as part of this particular proposal. If it's to support "future sorted collections," then the best motivating use cases would be found once those have been proposed, and perhaps the "customization points" are best bundled with them.</div><div><br></div><div>Nit: `sortedRange(of:)` could use a clearer name, maybe `sortedIndexRange(of:)`, since it's indices that we're talking about. Otherwise, it reads superficially like you might be getting a range of *values* back.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Is the problem being addressed significant enough to warrant a change to Swift?<br></blockquote><div><br></div><div>Yes.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Does this proposal fit well with the feel and direction of Swift?<br></blockquote><div><br></div><div>Yes.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></blockquote><div><br></div><div>The proposal itself does a nice job of comparing these facilities to C++ counterparts. I suspect I've got less experience with those than the authors themselves.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br></blockquote><div><br></div><div>I did a quick reading of the proposal; I've also used these algorithms before and rolled my own binary search in Swift.</div></div></div></div>