<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div><blockquote type="cite" class="">The review of "SE-0032: Add find method to SequenceType" begins now and runs through May 3. The proposal is available here:</blockquote><blockquote type="cite" class=""><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0032-sequencetype-find.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0032-sequencetype-find.md</a></blockquote><font color="#5856d6" class=""><br class=""><br class=""></font><blockquote type="cite" class=""><div class=""><div class="">* What is your evaluation of the proposal?</div></div></blockquote>-0 for naming reasons<br class=""><br class=""><blockquote type="cite" class=""><div class=""><div class="">* Is the problem being addressed significant enough to warrant a change to Swift?</div></div></blockquote>Sure<br class=""><blockquote type="cite" class=""><div class=""><div class=""><div class=""><br class=""></div>* Does this proposal fit well with the feel and direction of Swift?</div></div></blockquote>Not entirely. Because Sequence operations are based on the iterator, and the iterator is not guaranteed to be either non-destructive/resetting or finite, a find method could lead to subtle bugs.</div><div><br class=""></div><div>I would prefer either another name such as skipUntil, or that find exist on Collection which does have the guarantee of being non-destructive and resettable on iteration.</div><div><br class=""></div><div><blockquote type="cite" class=""><div class=""><div class=""><div class=""><br class=""></div>* If you have you used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</div></div></blockquote><div><br class=""></div>skipUntil is the closest I see in reactive programming sources, which process events as a stream rather than as a resettable cursor into a data structure.</div><div><br class=""></div><div><blockquote type="cite" class=""><div class=""><div class="">* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</div></div></blockquote><br class=""></div><div>A quick reading.</div><br class=""></body></html>