<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> * What is your evaluation of the proposal?<br></blockquote><div><br></div><div>Improved.</div><div><br></div><div>Suggestions re naming of `isLessThanOrEqualTo(_:)`:</div><div>"Less-than" can be regarded as a unit. Thus, `isLessThan(_:)` is reasonable. However, `isEqualTo(_:)` is kind of a stretch, but it could just be `equals(_:)`. Thus, you could have:</div><div>```</div><div>equals(_:)</div><div>isLessThan(_:)</div><div>isLessThanOrEquals(_:)</div><div>isGreaterThan(_:)</div><div>isGreaterThanOrEquals(_:)</div><div>isTotallyOrdered(below:)</div><div>```</div><div><br></div><div>Typos in comments (not exhaustive):</div><div>* Above `init(signOf:magnitudeOf:)`, comment should read "...exponent and significand are taken from `magnitudeOf`" instead of "...taken from `magnitude`"</div><div>* Above `isTotallyOrdered(below:)`, "preceeds" [sic] should be "precedes"</div><div><br></div><div>Other thoughts:</div><div>* I finally see why IEEE 754 calls it "minNum"--namely, "Num" implies strongly how NaNs are handled. (What's the minimum of 0 and NaN? I dunno, they're unordered. What's the minimum *number* given 0 and NaN? Well, it has to be 0, because NaN isn't a number.) I wonder if this is a useful thing to include in the Swift name (i.e. `minimumNumber`)</div><div>* Still not sure about ulpOfOne; if the point is to encourage people who incorrectly reach for DBL_EPSILON to understand what's going on, then by the time they learn what ULP is they should know that `(1.0).ulp == Double.ulpOfOne`</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Is the problem being addressed significant enough to warrant a change to Swift?<br></blockquote><div><br></div><div>Yes, as mentioned previously.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Does this proposal fit well with the feel and direction of Swift?<br></blockquote><div><br></div><div>Yes, fits much better with these revisions.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* If you have you used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br></blockquote><div><br></div><div>Compares favorably.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br></blockquote><div><br></div><div>Quick reading of revised proposal; in-depth study of earlier iterations.</div><div> </div></div></div></div>