<div style="white-space:pre-wrap">Type based access would be confusing, which is why the proposal was for scoped based access. This means that something is visible only in the scope in which it is defined and is completely sealed from outside of the scope. This way you have to modify the scope to make something more visible, so you can't just add another extension to make something more visible.<br><br>> Limiting access using scope means another file/module can just add a property/function to make the value public. Confusing type-based and file-based access is a step backwards, and any attempt to add type-based access shouldn't be a breaking change.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Mar 16, 2016 at 6:52 AM James Froggatt via swift-evolution <<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I agree with the proposal of ‘inherited’ & ‘declaration’ modifiers.<br>
<br>
Current access modifiers actually guarantee access. Limiting access using scope means another file/module can just add a property/function to make the value public. Confusing type-based and file-based access is a step backwards, and any attempt to add type-based access shouldn't be a breaking change.<br>
<br>
Replacing internal with private(module) also seems like a step backwards, to me, and in my opinion changes to the ‘internal’ keyword should be part of a separate proposal.<br>
<br>
Inherited & declaration modifiers compose well with existing access-modifiers, are clear in their purpose, can be applied to all access levels, and don't break existing code.<br>
<br>
------------ Begin Message ------------<br>
Group: gmane.comp.lang.swift.evolution<br>
MsgID: <<a href="mailto:CAPUwzK7YHzwDMTMuH1Qvbojz3%2B9%2BikgJvna3xDhscESVO8YSNQ@mail.gmail.com" target="_blank">CAPUwzK7YHzwDMTMuH1Qvbojz3+9+ikgJvna3xDhscESVO8YSNQ@mail.gmail.com</a>><br>
<br>
It's occurring to me, reading these recent posts, that we have two<br>
orthogonal systems of access levels.<br>
<br>
Swift's current access system is file based; a project file decides which<br>
files comprise a module, and the terms 'public', 'internal' and 'private'<br>
determine whether a property is accessible to all, accessible only within<br>
files of the module, or accessible only within a file. (This takes on an<br>
extra dimension as files may belong to several modules).<br>
<br>
The concept which began this discussion, and several of the proposed<br>
concepts in this discussion, ask instead for a type-based access system<br>
similar to those in other languages including Objective-C, where 'public',<br>
'protected' and 'private' are the terms of choice and they restrict access<br>
to a type or subtypes.<br>
<br>
I think it would be confusing if Swift applied 'public' to a concept in the<br>
file-based access system and 'private' to a concept in the type-based<br>
access system.<br>
<br>
I would prefer clearer terms which actually mention the restrictions of the<br>
level. For example, 'inherited', not 'protected', in the case of properties<br>
accessible by a class and its subclasses; 'declaration', rather than<br>
'private' or 'scoped', to refer to properties only accessible within a<br>
given type or extension declaration.<br>
<br>
Since, at the moment, a declaration can only occur within one file, I think<br>
this most-restricted level has managed to pass as a level of the file-based<br>
access system. However, if the system is ever extended, we're going to run<br>
into new syntax decisions where we have 'private module' functions<br>
(accessible only within the given type in the same module) trying to<br>
communicate with 'protected file' properties (accessible only with the type<br>
and its subtypes in the same file), and that might lead to conflicts, so<br>
perhaps we should decide how those might be declared now.<br>
<br>
On Tue, Mar 15, 2016 at 11:51 PM, Jonathan Hull via swift-evolution <<br>
<a href="mailto:swift-evolution-m3FHrko0VLzYtjvyW6yDsg@public.gmane.org" target="_blank">swift-evolution-m3FHrko0VLzYtjvyW6yDsg@public.gmane.org</a>> wrote:<br>
<br>
>On Tue, Mar 15, 2016 at 2:33 PM Erica Sadun <erica at <a href="http://ericasadun.com" rel="noreferrer" target="_blank">ericasadun.com</a> <<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a>>> wrote:<br>
><br>
>And again, moving the access control modification to the end just doesn't look<br>
>right to me or seem to enhance readability. :(<br>
><br>
>I like Shawn’s proposal better for cases where there are custom<br>
>getter/setter implementations. We should definitely be able to do:<br>
><br>
>var foo:Int {<br>
>public get {…}<br>
>private(file) set {…}<br>
>}<br>
><br>
>In fact, that is what I first tried to do before learning about<br>
>private(set). But without the implementations, it just seems strange to<br>
>put the scoping after the rest of the declaration (they work above because<br>
>they are *before* the custom getter/setter).<br>
><br>
>I still like the idea of having the option to use parameter-like syntax<br>
>for cases where you don’t have custom getters/setters:<br>
><br>
>private var foo:Int<br>
>private(file) var foo:Int<br>
>private(set: file) var foo:Int<br>
>private(get: global, set: file) var foo:Int<br>
><br>
><br>
>I guess, if we had some way to represent the standard getter/setter, that<br>
>might work too. I don’t love it, but maybe with better wording?<br>
><br>
>var foo:Int{<br>
>public get useDefault<br>
>private(file) set {…}<br>
>}<br>
><br>
>Thanks,<br>
>Jon<br>
><br>
><br>
>On Mar 14, 2016, at 10:22 PM, Patrick Pijnappel <<br>
><a href="mailto:patrickpijnappel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" target="_blank">patrickpijnappel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org</a>> wrote:<br>
><br>
>I like Shawn's proposal:<br>
><br>
><br>
><br>
>var foo: Int { private(file) set }<br>
><br>
><br>
>>In fact it's probably more sensible than the current private(set) IMO.<br>
><br>
><br>
>For example, we already use<br>
><br>
>var foo: Int { mutating get { ... } }<br>
><br>
>and not<br>
><br>
>mutating(get) var foo: Int { get { ... } }<br>
><br>
>On Tue, Mar 15, 2016 at 4:13 PM, Patrick Pijnappel <<br>
><a href="mailto:patrickpijnappel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" target="_blank">patrickpijnappel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org</a>> wrote:<br>
><br>
>>I like Shawn's proposal:<br>
>><br>
>>var foo: Int { private(file) set }<br>
>><br>
>>In fact it's probably more sensible than the current private(set) IMO.<br>
>><br>
>><br>
>>While I like private(get: file, set: module) idea, I think it just gets<br>
>>too inconsistent with private(set: public) and private(set: private) (?!)<br>
>><br>
>>On Tue, Mar 15, 2016 at 3:39 PM, Jonathan Hull via swift-evolution <<br>
>><a href="mailto:swift-evolution-m3FHrko0VLzYtjvyW6yDsg@public.gmane.org" target="_blank">swift-evolution-m3FHrko0VLzYtjvyW6yDsg@public.gmane.org</a>> wrote:<br>
>><br>
>>>*On Mar 14, 2016, at 8:36 PM, Patrick Pijnappel via swift-evolution <swift-evolution at <a href="http://swift.org" rel="noreferrer" target="_blank">swift.org</a> <<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a>>> wrote:*<br>
>>><br>
>>>The only question is (as Sean mentioned) how this combines with the syntax<br>
>>>for setter access level, e.g. the current private(set). Options:<br>
>>>- Unnamed 2nd argument, giving private(file), private(file, set),<br>
>>>private(set).<br>
>>>- Named 2nd argument, giving e.g. private(file), private(file, accessor:<br>
>>>set), private(accessor: set). Less ambiguity but longer.<br>
>>>- Not using multiple arguments, but that'd probably break consistency with<br>
>>>the other unification efforts going on to make everything look like<br>
>>>function calls.<br>
>>><br>
>>>What about the following 3 forms?<br>
>>><br>
>>>private(file) //both setter and getter have file scope<br>
>>>private(set: file) //setter has file scope. Equivalent to current<br>
>>>“private(set)"<br>
>>>private(get: module, set: file) //getter has module scope & setter has<br>
>>>file scope<br>
>>><br>
>>>It is a bit weird, but we should probably also allow “public" in that<br>
>>>last form: private(get: public, set: module)<br>
>>><br>
>>>Thanks,<br>
>>>Jon<br>
>>><br>
>>>_______________________________________________<br>
>>>swift-evolution mailing list<br>
>>><a href="mailto:swift-evolution-m3FHrko0VLzYtjvyW6yDsg@public.gmane.org" target="_blank">swift-evolution-m3FHrko0VLzYtjvyW6yDsg@public.gmane.org</a><br>
>>><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
>>><br>
>>><br>
>><br>
><br>
><br>
>_______________________________________________<br>
>swift-evolution mailing list<br>
><a href="mailto:swift-evolution-m3FHrko0VLzYtjvyW6yDsg@public.gmane.org" target="_blank">swift-evolution-m3FHrko0VLzYtjvyW6yDsg@public.gmane.org</a><br>
><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
><br>
><br>
<br>
<br>
<br>
------------- End Message -------------<br>
<br>
<br>
<br>
>From James F<br>
_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
</blockquote></div>