<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><div class=""><div class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><p class="" style="box-sizing: border-box; margin-top: 0px; margin-bottom: 16px;"><font color="#000000"><span style="background-color: rgba(255, 255, 255, 0);">Proposal link:</span></font></p><blockquote class="" style="box-sizing: border-box; margin: 0px 0px 16px; padding: 0px 15px; border-left-width: 4px; border-left-style: solid; border-left-color: rgb(221, 221, 221);"><div class="" style="box-sizing: border-box; margin-top: 0px; margin-bottom: 0px;"><font class="" color="#000000"><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0023-api-guidelines.md" class="" style="background-color: rgba(255, 255, 255, 0);">https://github.com/apple/swift-evolution/blob/master/proposals/0023-api-guidelines.md</a></font></div></blockquote></div></div></div></div><div id="AppleMailSignature"><br></div><div class=""><div class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><ul class="" style="box-sizing: border-box; padding: 0px 0px 0px 2em; margin-top: 0px; margin-bottom: 16px;"><li class="" style="box-sizing: border-box;"><font color="#000000"><span style="background-color: rgba(255, 255, 255, 0);"><b>What is your evaluation of the proposal?</b></span></font></li></ul><div>+1</div><div><br></div><div>I read the guidelines and I like them a lot in general. I think they are a very good start. </div><div><br></div><div>I have read the alternatives and disagreements in the discussion threads. However, in my opinion the guidelines still stand as the winner. I find it better, simpler, more concise and better looking than the alternatives discussed. </div><div><br></div><div>For example the <b>ed/ ing ending</b> for non-mutable methods. This is a convention I have used in java for a long time and I found it very natural in general even when the English language may not cooperate as it has been discussed by others. I got used to this convention very quickly many years ago in libraries I use in java. </div><div><br></div><div><b>There is only one guideline that I think is not aligned with the consensus I seem to pick up from the discussions.</b> That is the use of camel case for enum cases. After reading different opinions I am now leaning towards saying that <b>Enum cases should be lower camel case</b> given that they are values. At first my opinion was the same as the guideline. After reading the discussions and seeing examples I changed my mind. </div><div><br></div><div><br></div><ul class="" style="box-sizing: border-box; padding: 0px 0px 0px 2em; margin-top: 0px; margin-bottom: 16px;"><li class="" style="box-sizing: border-box;"><font color="#000000"><span style="background-color: rgba(255, 255, 255, 0);"><b>Is the problem being addressed significant enough to warrant a change to Swift?</b></span></font></li></ul><div>This will bring a lot of changes when applied. I think they are a good start. I don't think it should cover all cases. </div><div><br></div><div>I saw the <b>loginWithUserName(_:password:) </b><span style="background-color: rgba(255, 255, 255, 0);">example </span>and alternatives: <b>login(userName:password:)</b>, etc. I don't know if this is addressed in the guidelines. I don't think this example falls under the weak type first argument. It would be nice to have some guidance here. I do not know how to state it but I think in this case I would say <span style="background-color: rgba(255, 255, 255, 0);"><b>login(userName:password:)</b> is better as it could be part of a family of login() methods that take different parameters, i.e. credentials. </span></div><div><br></div><ul class="" style="box-sizing: border-box; padding: 0px 0px 0px 2em; margin-top: 0px; margin-bottom: 16px;"><li class="" style="box-sizing: border-box;"><font color="#000000"><span style="background-color: rgba(255, 255, 255, 0);"><b>Does this proposal fit well with the feel and direction of Swift?</b></span></font></li></ul><div>Definitely. I find the guidelines are concise, natural and easy to get used to. </div><div><br></div><ul class="" style="box-sizing: border-box; padding: 0px 0px 0px 2em; margin-top: 0px; margin-bottom: 16px;"><li class="" style="box-sizing: border-box;"><font color="#000000"><span style="background-color: rgba(255, 255, 255, 0);"><b>If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?</b></span></font></li></ul><div>I have used Java libraries for many years that use the <b>ed</b> ending for non-mutable methods for example. </div><div><br></div><ul class="" style="box-sizing: border-box; padding: 0px 0px 0px 2em; margin-top: 0px; margin-bottom: 16px;"><li class="" style="box-sizing: border-box;"><font color="#000000"><span style="background-color: rgba(255, 255, 255, 0);"><b>How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</b></span></font></li></ul><div>I read the proposal entirely and I have read the majority of responses in the mailing list. </div></div></div></div></div></div></body></html>