<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><blockquote type="cite" class="" style="font-family: TimesNewRomanPSMT;"><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><span class="Apple-tab-span" style="white-space: pre;"> </span>* What is your evaluation of the proposal?</div></blockquote><div class=""><br class=""></div><div class="">This proposal does solve a real problem.</div><div class="">I have one concern about that proposal though: this is solving a compiler ambiguity, but I think it would introduce a "visual" ambiguity :</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>let variable = function(arg1, argName: arg2) // function call</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>let variable = function (_:, argName:) // assign function to a variable</div><div class="">Those who lines, despite being pretty close visually, are very different.</div><div class="">I have the feeling that it might make non-obvious pieces a bit harder to read. That could reduce swift readability.</div><div class=""><br class=""></div><div class="">Todays method (using a closure) is more verbose, but it is less ambiguous visually I think.</div><div class="">I would be happy to have this possibility, but not at the cost of code readability.</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="" style="font-family: TimesNewRomanPSMT;"><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">* Is the problem being addressed significant enough to warrant a change to Swift?</div></blockquote><br class=""></div><div class="">As a developper, I didn't encounter that situation a lot : I assign closures to variables much more than functions.</div><div class="">Nevertheless, the current situation sounds a bit like an incoherency between the way swift identifies methods internally and the way the developper can refer to methods. I am absolutely no expert in compilers, but can that be a flaw that would become problematic later on ? Sorry, I cannot say :-). But if it is, then the problem surely is significant enough to be addressed.</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="" style="font-family: TimesNewRomanPSMT;"><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">* Does this proposal fit well with the feel and direction of Swift?</div></blockquote><br class=""></div><div class="">As explained before, I feel the syntax proposed in that evolution has a cost on readability, as it makes two very different things very similar visually.</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="" style="font-family: TimesNewRomanPSMT;"><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?</div></blockquote><br class=""></div><div class=""><span style="font-family: TimesNewRomanPSMT;" class="">I’ve read the discussion on swift-evolution and the final proposal on GitHub.</span></div><div class="">I have to say that I didn't even found a syntax that I could propose to avoid the visual ambiguity.</div><div class=""><br class=""></div><div class="">Jerome</div><br class=""><div><blockquote type="cite" class=""><div class="">Le 13 janv. 2016 à 18:16, Joe Groff via swift-evolution <<a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a>> a écrit :</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hello Swift community,<br class=""><br class="">The review of "Naming Functions with Argument Labels" begins now and runs through January 10th. The proposal is available here:<br class=""><br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span><a href="https://github.com/apple/swift-evolution/blob/master/proposals/0018-flexible-memberwise-initialization.md" class="">https://github.com/apple/swift-evolution/blob/master/proposals/0021-generalized-naming.md</a><br class=""><br class="">Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at<br class=""><br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" class="">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br class=""><br class="">or, if you would like to keep your feedback private, directly to the review manager.<br class=""><br class="">What goes into a review?<br class=""><br class="">The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:<br class=""><br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>* What is your evaluation of the proposal?<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>* Is the problem being addressed significant enough to warrant a change to Swift?<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>* Does this proposal fit well with the feel and direction of Swift?<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>* If you have you used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?<br class=""><br class="">More information about the Swift evolution process is available at<br class=""><br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span><a href="https://github.com/apple/swift-evolution/blob/master/process.md" class="">https://github.com/apple/swift-evolution/blob/master/process.md</a><br class=""><br class="">Thank you,<br class=""><br class="">-Joe<br class="">Review Manager<br class="">
<img src="https://u2002410.ct.sendgrid.net/wf/open?upn=ZfNDJ3c1KY40DpRPxaBpmw0PAd1TZW0h3lqFWlwcZNUCofbdEvLB6zu4OD0kz0YDWRV8w4Zb5TjM4xmaUh4-2FfOhu-2BShwOh2T7MFCVlC1QAREdrtMh1gpkSPw4CYKsQQR6dlQB48-2FDR2weflZ7zu2Iq7a4eBrG5Y20CRYPTcz776U3md6XgDAon1By-2B8OVxQt8Qfkpc2WvDr5sDszaHKGbvZdbXrv8LB4d2s5RV0VoCQ-3D" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;" class="">
</div>
_______________________________________________<br class="">swift-evolution mailing list<br class=""><a href="mailto:swift-evolution@swift.org" class="">swift-evolution@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-evolution<br class=""></div></blockquote></div><br class=""></body></html>