<div dir="ltr">Loving those commits! Especially the corresponding tests :)<br><br>Can you explain the decision to not go through the review process? I think it's a prudent decision and I'm supportive of it, but I was under the impression that additional APIs should be proposed and reviewed. Is the rationale that swift-corelibs-xctest is too immature to justify going through proposals?<div><div><br></div><div>- Brian Gesiak<br><div><br></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 13, 2016 at 4:52 PM, Chris Hanson via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Thanks, everyone, for all of the feedback.<div><br></div><div>I sent this proposal out as more of a “heads up” that we were planning to make these changes and get feedback in advance of that, so we won’t be taking this through the full proposal process. That said, here’s what we’re going to be doing:</div><div><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div>1. We’re going to let test methods throw, and treat those as unexpected failures, as planned.</div><div><br></div><div>2. We’re going to let test assertion expressions throw, and treat those as unexpected failures, as planned. We recognize that this will result in slightly different style in tests versus in regular code, but the convenience and reduction in boilerplate makes this worthwhile.</div><div><br></div><div>3. We’re going to add the <font face="Menlo"><span style="font-size:11px">XCTAssertThrowsError</span></font> assertion, incorporating Kevin Ballard’s suggestion for how to avoid the “<font face="Menlo" style="font-size:11px">_ = blah()</font>” in its expression.</div><div><br></div><div>4. We’re <i>not</i> going to add the ability for <font face="Menlo"><span style="font-size:11px">XCTAssertThrowsError</span></font> to check that a specific error was thrown. This could definitely be useful but would require the function to take an <font face="Menlo"><span style="font-size:11px">ErrorType</span></font> instance that also conforms to <font face="Menlo"><span style="font-size:11px">Equatable</span></font>. We need to think about that some more before making such a change. Fortunately this sort of addition will be straightforward to put in via an overload or default argument, so if we choose to do it later, it shouldn’t break any code that starts to adopt <font face="Menlo"><span style="font-size:11px">XCTAssertThrowsError</span></font>.</div></blockquote><div><br></div><div>We’re going to start landing these changes today, so thanks again for all of your attention and feedback!</div><div><br></div><div> -- Chris</div><div><br></div>
<img src="https://u2002410.ct.sendgrid.net/wf/open?upn=RwYb2GKd-2F4OO18dA6Iy-2B3LrStHfLgivaBZlWDE47E-2FK-2FtzQmQ-2FdfVC5GCL-2B2hzJcKbithr0Jb61cYj1d2fxQ5dbcvlwhbMR7c5-2BzxtUX3GqWBrulVXLlLGTkyiaa6S6mIssZNfUlPjyjtszWchjhV5NcVLAJQJBWqiRVyaj5qZJ0a4CDKS-2FrPWqoK-2FAMAHgMV9z5C4shwtZSakcO9-2BPDIqD2as1lAlbjzKJC3inICdU-3D" alt="" width="1" height="1" border="0" style="min-height:1px!important;width:1px!important;border-width:0!important;margin-top:0!important;margin-bottom:0!important;margin-right:0!important;margin-left:0!important;padding-top:0!important;padding-bottom:0!important;padding-right:0!important;padding-left:0!important">
</div>
<br>_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
<br></blockquote></div><br></div>