<div dir="ltr">All,<div><br></div><div>I agree, the UITableViewController example was poor. I couldn't pull out another example without being extremely abstract. I used UITableVC to delineate the hierarchy more than to delineate the actual benefit of my suggestion.</div><div><br></div><div>My goal, in one line, is to have the ability enforce certain (marked/flagged) methods in a subclass to explicitly override their parent's protocol-conformed methods. I chose @abstract as it's a known keyword. Personally, @requires_override is my favorite suggestion thus far.</div><div> </div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 15, 2015 at 9:43 AM Etan Kissling via swift-evolution <<a href="mailto:swift-evolution@swift.org">swift-evolution@swift.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Would maybe stick with @abstract or @deferred instead of the verbose @requires_override as the keyword.<div>Those keywords are known from other languages.</div><div><br></div><div>+1 with the rest, though.</div><div><br></div><div>It's really a pain to not have access to abstract classes.</div><div>My workaround for similar cases is</div><div>- Put function definitions with deferred implementation into protocols.</div><div>- Mark initializer of base class as private to prevent instantiation of the incomplete class.</div><div>- Put subclasses into same file as base class.</div><div>- In subclass, inherit from both the base class and the protocol, and override initializer as public.<br><div><br></div><div>Also agree with the irrelevance for UITableViewController. The class works perfectly fine without the overrides.</div></div></div><div style="word-wrap:break-word"><div><div><br></div><div>Etan</div></div></div><div style="word-wrap:break-word"><div><div><br><div><blockquote type="cite"><div>On 14 Dec 2015, at 00:27, Kevin Ballard via swift-evolution <<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>> wrote:</div><br><div>
<div><div>Seems to me this doesn't actually make sense on protocols at all. The scenario of a base superclass like UITableViewController that conforms to a protocol but only makes sense if its children override methods doesn't actually have anything to do with the protocol at all, as it's certainly not true any class that conforms to UITableViewDelegate/DataSource wants subclasses to override methods, that's only true of UITableViewController.<br></div>
<div> </div>
<div>Given that, the proposed @abstract is actually something that would make sense to put on the implementation of a method in a class, not on a protocol. There's simply no such thing as an abstract protocol. And when put on a method, it would probably be better to just call it @requires_override, because that's all it means.<br></div>
<div> </div>
<div>All that said, it doesn't actually make sense to put the attribute on UITableViewController's methods either. And the reason for that is that if you use a storyboard with static cells, you can have a UITableViewController that functions perfectly fine without overriding any of the UITableViewDelegate/DataSource methods. So requiring that a subclass implement any of those methods would actually be wrong.<br></div>
<div> </div>
<div>So overall, there are use-cases for a @requires_override attribute, but UITableViewController actually isn't one of them (in fact, I don't think anything in UIKit/Foundation qualifies).<br></div>
<div> </div>
<div>Regarding `required`, that's not appropriate because `required` means that every single descendant class must provide an implementation. And it's only allowed on init methods because the whole point of `required` is to remove the special-cased behavior of init for subclassing (e.g. that it's not inherited by subclasses). There's no other place besides init() where it makes sense to require every single descendant class to provide an implementation because every other method will get inherited (and even if your base class's implementation should always be overridden, if your child overrides it, your grandchild certainly doesn't have to!).<br></div>
<div> </div>
<div>-Kevin Ballard</div>
<div> </div>
<div>On Sun, Dec 13, 2015, at 02:16 PM, Jacob Bandes-Storch via swift-evolution wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div>How about reusing the keyword "required" for this? It's already used (and has a similar meaning) for initializers.<br></div>
<div> </div>
<div>I think NSSecureCoding is a good example of a use case.<br></div>
<div><div> </div>
<div><div>On Sat, Dec 12, 2015 at 9:14 AM, Arthur Ariel Sabintsev via swift-evolution <span dir="ltr"><<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a>></span> wrote:<br></div>
<blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div>TL;DR: Force explicit protocol conformance of non-optional methods for child classes on an opt-in basis.<br></div>
<div> </div>
<div>Currently, a child class that inherits their parent class' protocol conformations are not explicitly required to override their parent classes implementation of a protocol. For example, a custom class, MyTableViewController, does not explicitly have to override the non-optional methods of the protocols (i.e., UITableViewDataSource, UITableViewDelegate) to which UITableViewController conforms. <br></div>
<div> </div>
<div>For many protocols, the superclass implementation of a protocol method may be enough. Therefore, this feature should off by default, and only enabled if the creator of the protocol requires it (for whatever reason). I suggest using a new `@abstract` attribute to designate if a protocol requires explicit conformance for children of a conforming parent class. This choice of naming for the attribute is along the lines of what other languages call an Abstract Class, which is what I'm trying to have added to Swift in this fairly long-winded post.<br></div>
<div> </div>
<div>@abstract protocol P: class {<br></div>
<div> // All methods defined in here would need to be explicitly overridden by the conforming class's children.<br></div>
<div>}<br></div>
<div> </div>
<div>If you want to have optional methods in your protocol, then using the @abstract attribute gets kind of messy, as you also have the @objc attribute.<br></div>
<div><div> </div>
</div>
<div><div>@abstract @objc protocol P: class {<br></div>
<div> // All non-optional methods defined in here would need to be explicitly overridden by the conforming class's children.<br></div>
<div>}<br></div>
</div>
<div> </div>
<div>Thoughts?<br></div>
<div> </div>
<div><div><div dir="ltr"><div><div dir="ltr"><div style="font-family:helvetica,arial"><span style="color:rgb(34,34,34)"><span style="font-family:arial,sans-serif">Best,</span></span><br></div>
<div style="font-family:helvetica,arial"> </div>
<div style="font-family:helvetica,arial"><span style="color:rgb(34,34,34)"><span style="font-family:arial,sans-serif">Arthur / <a href="http://sabintsev.com/" target="_blank">Sabintsev.com</a></span></span><br></div>
</div>
</div>
</div>
</div>
</div>
</div>
<div><img style="min-height:1px!important;width:1px!important;border-top-width:0px!important;border-right-width:0px!important;border-bottom-width:0px!important;border-left-width:0px!important;margin-top:0px!important;margin-bottom:0px!important;margin-right:0px!important;margin-left:0px!important;padding-top:0px!important;padding-bottom:0px!important;padding-right:0px!important;padding-left:0px!important" border="0" height="1" width="1" alt="" src="https://www.fastmailusercontent.com/proxy/5107855c90121e85e876e3bca775a895d280b9ee915b5c0c15464bbdff448427/8647470737a3f2f25723030323431303e23647e23756e64676279646e2e65647f27766f2f60756e6f35707e6d305d2232437952624a584252457c44424a416c4434494b444e466b6b6a60725f4f67745972514f4266513131797669345276527e49516c4834325279653379317d41313957513d46626131454933617a6f655734396a457c4757347075744d22364247633e694531537647335769656d2236443a46695e4356426a5165455467455464495645566f65447e68787464733735687c6267413a614441667d4853446f426d6e49327d437f4e415169324d2232465248535e4a535363365843555752467d2236424b6657766b4470596248697c6744724173776536787f4a48317b68387363455531575f4478796d223648657c686f62454d2232443d23344/open"> <br></div>
<div>_______________________________________________<br></div>
<div>
swift-evolution mailing list<br></div>
<div> <a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br></div>
<div> <a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br></div>
<div> </div>
</blockquote></div>
</div>
</div>
<div><img style="min-height:1px!important;width:1px!important;border-top-width:0px!important;border-right-width:0px!important;border-bottom-width:0px!important;border-left-width:0px!important;margin-top:0px!important;margin-bottom:0px!important;margin-right:0px!important;margin-left:0px!important;padding-top:0px!important;padding-bottom:0px!important;padding-right:0px!important;padding-left:0px!important" border="0" height="1" width="1" alt="" src="https://www.fastmailusercontent.com/proxy/649edb3c32a2262c2151f8f0ec4ddac7bedf00713aeb360a5cc2f2f023fddc71/8647470737a3f2f25723030323431303e23647e23756e64676279646e2e65647f27766f2f60756e6f35707e6d3148765176786c673171614a7d2236454230345272776e41677a615154425354673d2232496e4334724667427940383a4f65584c4c64487b67727974534e4c655d69585b616849413d22324733797a526a41364742353b6a7664796a43375054523e43733750523f46566670745e42723933417f653a43727b66395d624f6945403136405d223643664851793e667e614e41455243544166646a644573403c6c4a71303f4867787436317138724d44313d223648677054657d2236455d4e463977516a617d613d4d22364c61566965554371485f6b63617835547a63544c67636a7e6a576d23344d23344/open"><br></div>
<div><u>_______________________________________________</u><br></div>
<div>swift-evolution mailing list<br></div>
<div><a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br></div>
<div><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br></div>
</blockquote><div> </div>
<img src="https://u2002410.ct.sendgrid.net/wf/open?upn=tTTJ5sn5y0uc3ODSZa-2BndLNwXCDS7T2cq5OlDDhG0RvNtFFWhH5kDG49Z7rE63kkWfNXj14C3cbRchCugB1n6a1ZHBZlc8kO4BVws29LDjMfrjYZQ5RFMpeq7FxqbxpXLJfEKTRPXFFyw3eJiiZ5FQM0Sxi6UM0XyXNdra26whv6C63t4IJV44eiPdVlxD9hkwiwm23yvdNMZtDJDrTkEpvl6zGpF7oMJPJHrKsJJfs-3D" alt="" width="1" height="1" border="0" style="min-height:1px!important;width:1px!important;border-width:0!important;margin-top:0!important;margin-bottom:0!important;margin-right:0!important;margin-left:0!important;padding-top:0!important;padding-bottom:0!important;padding-right:0!important;padding-left:0!important">
</div>
_______________________________________________<br>swift-evolution mailing list<br><a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br><a href="https://lists.swift.org/mailman/listinfo/swift-evolution" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br></div></blockquote></div><br></div></div></div>_______________________________________________<br>
swift-evolution mailing list<br>
<a href="mailto:swift-evolution@swift.org" target="_blank">swift-evolution@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-evolution" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-evolution</a><br>
</blockquote></div><div dir="ltr">-- <br></div><div dir="ltr">Best,<div><br></div><div>Arthur / Sabintsev.com</div></div>