[swift-evolution] [Proposal] Random Unification

[Xiaodi Wu]

On Fri, Nov 17, 2017 at 7:11 PM, Brent Royal-Gordon <brent at architechies.com>
wrote:

> On Nov 17, 2017, at 3:09 PM, Xiaodi Wu via swift-evolution <
> swift-evolution at swift.org> wrote:
>
> But actually, Int.random followed by % is the much bigger issue and a very
> good cautionary tale for why T.random is not a good idea. Swift should help
> users do the correct thing, and getting a random value across the full
> domain and computing an integer modulus is never the correct thing to do
> because of modulo bias, yet it's a very common error to make. We are much
> better off eliminating this API and encouraging use of the correct API,
> thereby reducing the likelihood of users making this category of error.
>
>
> Amen.
>
> If (and I agree with this) the range-based notation is less intuitive
> (0..<10.random is certainly less discoverable than Int.random), then we
> ought to offer an API in the form of `Int.random(in:)` but not
> `Int.random`. This does not preclude a `Collection.random` API as Alejandro
> proposes, of course, and that has independent value as Gwendal says.
>
>
> If we're not happy with the range syntax, maybe we should put
> `random(in:)`-style methods on the RNG protocol as extension methods
> instead. Then there's a nice, uniform style:
>
> let diceRoll = rng.random(in: 1...6)
> let card = rng.random(in: deck)
> let isHeads = rng.random(in: [true, false])
> let probability = rng.random(in: 0.0...1.0) // Special FloatingPoint
> overload
>
> The only issue is that this makes the default RNG's name really important.
> Something like:
>
> DefaultRandom.shared.random(in: 1...6)
>
> Will be a bit of a pain for users.
>

I did in fact implement this style of RNG in NumericAnnex, but I'm not
satisfied with the design myself. Not only is it a bit of an ergonomic
thorn, there's also another drawback that actually has weighty implications:

Users aren't conditioned to reuse RNG instances. Perhaps, it is because it
can "feel" wrong that multiple random instances should come from the *same*
RNG. Instead, it "feels" more right to initialize a new RNG for every
random number. After all, if one RNG is random, two must be randomer! This
error is seen with some frequency in other languages that adopt this
design, and they sometimes resort to educating users through documentation
that isn't consistently heeded.

Of course, you and I both know that this is not ideal for performance.
Moreover, for a number of PRNG algorithms, the first few hundred or
thousand iterations can be more predictable than later iterations. (Some
algorithms discard the first n iterations, but whether that's adequate
depends on the quality of the seed, IIUC.) Both of these issues don't apply
specifically to a default RNG type that cannot be initialized and always
uses entropy from the global pool, but that's not enough to vindicate the
design, IMO. By emphasizing *which* RNG instance is being used for random
number generation, the design encourages non-reuse of non-default RNGs,
which is precisely where this common error matters for performance (and
maybe security).

Maybe we call the default RNG instance `random`, and then give the
> `random(in:)` methods another name, like `choose(in:)`?
>
> let diceRoll = random.choose(in: 1...6)
> let card = random.choose(in: deck)
> let isHeads = random.choose(in: [true, false])
> let probability = random.choose(in: 0.0...1.0)
> let diceRoll = rng.choose(in: 1...6)
> let card = rng.choose(in: deck)
> let isHeads = rng.choose(in: [true, false])
> let probability = rng.choose(in: 0.0...1.0)
>
> This would allow us to keep the default RNG's type private and expose it
> only as an existential—which means more code will treat RNGs as black
> boxes, and people will extend the RNG protocol instead of the default RNG
> struct—while also putting our default random number generator under the
> name `random`, which is probably where people will look for such a thing.
>

I've said this already in my feedback, but it can get lost in the long
chain of replies, so I'll repeat myself here because it's relevant to the
discussion. I think one of the major difficulties of discussing the
proposed design is that Alejandro has chosen to use a property called
"random" to name multiple distinct functions which have distinct names in
other languages. In fact, almost every method or function is being named
"random." We are tripping over ourselves and muddling our thinking (or at
least, I find myself doing so) because different things have the exact same
name, and if I'm having this trouble after deep study of the design, I
think it's a good sign that this is going to be greatly confusing to users
generally.

First, there's Alejandro's _static random_, which he proposes to return an
instance of type T given a type T. In Python, this is named `randint(a, b)`
for integers, and `random` (between 0 and 1) or `uniform(a, b)` for
floating-type types. The distinct names reflect the fact that `randint` and
`uniform` are mathematically quite different (one samples a *discrete*
uniform distribution and the other a *continuous* uniform distribution),
and I'm not aware of non-numeric types offering a similar API in Python.
These distinct names accurately reflect critiques from others on this list
that the proposed protocol `Randomizable` lumps together types that don't
share any common semantics for their _static random_ method, and that the
protocol is of questionable utility because types in general do not share
sufficient semantics such that one can do interesting work in generic code
with such a protocol.

Then there's Alejandro's _instance random_, which he proposes to return an
element of type T given a instance of a collection of type T. In Python,
this is named "choice(seq)" (for one element, or else throws an error) and
"sample(seq, k)" (for up to k elements). As I noted, Alejandro was right to
draw an analogy between _instance random_ and other instance properties of
a Collection such as `first` and `last`. In fact, the behavior of Python's
"choice" (if modified to return an Optional) and "sample", as a pair, would
fit in very well next to Swift's existing pairs of `first` and `prefix(k)`
and `last` and `suffix(k)`. We could trivially Swiftify the names here; for
example:

```
[1, 2, 3].first
[1, 2, 3].any // or `choice`, or `some`, or...
[1, 2, 3].last

[1, 2, 3].prefix(2)
[1, 2, 3].sample(2)
[1, 2, 3].suffix(2)
```

I'm going to advocate again for _not_ naming all of these distinct things
"random". Even in conducting this discussion, it's so hard to keep track of
what particular function a person is giving feedback about.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20171117/072c7949/attachment.html>