[swift-evolution] [Review] SE-0187: Introduce Sequence.filterMap(_:)

Joseph Lord joseph at human-friendly.com
Fri Nov 10 20:06:57 CST 2017


 > • What is your evaluation of the proposal?

-1

Code churn, new function name has the same issues as the old one. 
Benefits small. It is also likely that those suffering with the String 
collectionifying will have already solved their issues before this 
update could be introduced.

 > • Is the problem being addressed significant enough to warrant a 
change to Swift?

No.

 > • Does this proposal fit well with the feel and direction of Swift?

Distraction from major directions, little gain.

 > • How much effort did you put into your review? A glance, a quick 
reading, or an in-depth study?

Read proposal and scanned the discussion so far in this review.

We did actually hit the bug where a String was flatMapped and behaviour 
changed in Swift 4 migration a couple of weeks ago which caused some 
discussion to find out what the issue was but we solved it and there is 
a fair chance the renamed version could equally have had exactly the 
same issue.

Joseph


More information about the swift-evolution mailing list