[swift-evolution] [Review] SE-0173: Add `MutableCollection.swap(_:with:)

Ben Cohen ben_cohen at apple.com
Wed Apr 26 18:33:15 CDT 2017

Hi everyone,

Regarding the naming of the method: we discussed this amongst the core team and the feeling is that elements.swapAt(i, j) is the appropriate choice. We have a specific exception in the API naming guidelines around a preposition at the end of a base name, when the preposition applies to both arguments, and this falls under that case.

(this also happens to avoid the need for a work around for the source compatibility issue with shadowing the existing swap method – which isn't the determining factor, but is a nice side-effect)


> On Apr 25, 2017, at 11:32 AM, Ted Kremenek via swift-evolution <swift-evolution at swift.org> wrote:
> Hello Swift community,
> The review of SE-0173 "Add MutableCollection.swap(_:with:)" begins now and runs through April 28, 2017.
> The proposal is available here:
> https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md <https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md>
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:
> https://lists.swift.org/mailman/listinfo/swift-evolution <https://lists.swift.org/mailman/listinfo/swift-evolution>
> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
> Proposal link:
> https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md <https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md>
> Reply text
> Other replies
> What goes into a review?
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> What is your evaluation of the proposal?
> Is the problem being addressed significant enough to warrant a change to Swift?
> Does this proposal fit well with the feel and direction of Swift?
> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> More information about the Swift evolution process is available at:
> https://github.com/apple/swift-evolution/blob/master/process.md <https://github.com/apple/swift-evolution/blob/master/process.md>
> Thank you,
> Ted (Review Manager)
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170426/130cc97a/attachment.html>

More information about the swift-evolution mailing list