[swift-evolution] [Review #2] SE-0161: Smart KeyPaths: Better Key-Value Coding for Swift

[David Beck]

> Hello Swift community,
> 
> The second review of SE-0161 "Smart KeyPaths: Better Key-Value Coding for Swift" begins now and runs through April 9, 2017. The revised proposal is available here:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0161-key-paths.md<https://github.com/apple/swift-evolution/blob/master/proposals/0161-key-paths.md>
> The core team’s feedback from the first review of this proposal can be viewed at:
> 
> https://lists.swift.org/pipermail/swift-evolution-announce/2017-April/000342.html<https://lists.swift.org/pipermail/swift-evolution-announce/2017-April/000342.html>
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> 
> https://lists.swift.org/mailman/listinfo/swift-evolution<https://lists.swift.org/mailman/listinfo/swift-evolution>
> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
> 
> Proposal link:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0161-key-paths.md<https://github.com/apple/swift-evolution/blob/master/proposals/0161-key-paths.md>
> Reply text
> Other replies
> <https://github.com/apple/swift-evolution/pulls#what-goes-into-a-review-1>What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> What is your evaluation of the proposal?

I’m a very big fan of solving this problem, and this seems like a pretty flexible solution for the future.

I like the “::” solution, but could live with the proposed syntax. Also, that seems like an aspect that could be changed, either additively, or at the very least without breaking ABI stability.

> Is the problem being addressed significant enough to warrant a change to Swift?

YES! While KVO and KVC are big use cases for key paths, other use cases exist that make sense for non-objc code to use, especially db related models.

> Does this proposal fit well with the feel and direction of Swift?

For the most part. Like many have said, the slash is a little out of place, but hen again, that’s why it was chosen, so that it doesn’t conflict with other operators.

> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

Most languages that I’ve used this kind of feature with (including ObjC) just use stringly typed constructs, which have obvious issues.

> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

a quick reading

> More information about the Swift evolution process is available at
> 
> https://github.com/apple/swift-evolution/blob/master/process.md<https://github.com/apple/swift-evolution/blob/master/process.md>
> Thank you,
> 
> -Doug
> 
> Review Manager
> 
> 
>  


David Beck
davidb at acst.com
http://www.acstechnologies.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170410/c0a1ad97/attachment.html>