[swift-evolution] [swift-evolution-announce] [Review] SE-0169: Improve Interaction Between private Declarations and Extensions

Fri Apr 7 09:58:53 CDT 2017

On 07.04.2017 16:56, Shawn Erickson via swift-evolution wrote:
> -1 (strongish) on this proposal for the reason I comment earlier in the
> discussion thread.
>
> This weakens private for not an atypical use case of private that I
> currently have. It muddies the water between fileprivate and private making
> private more confusing and in away surprising. We have a clear and explicit
> way in fileprivate to do what this proposal does by tweaking private. I get
> that folks don't like fileprivate the word but I don't see that being a
> strong enough reason to take things in this direction. It also builds on
> file based access scoped which I believe is not the direction we should be
> going in a modern language such as swift.
>
> If changes are this strongly desired I believe we should bite the bullet
> and rename "private" to "scope[d]" and "fileprivate" to "private". Then
> work on making this renamed private work across files coupled either with a
> submodule concept (likely tagging wholes file as existing in a module)
> and/or making it work across extensions or class trees. ...or as suggested
> by others leave "private" as is and just rename "fileprivate" to "shared"

.. or to "local", as "shared" is confusing if it is shared with all module. 
The meaning of "local" is also not 100% obvious, but:
* IMO it is not hard to tech public->internal->local->private
(internal for module, local for file/submodule, private for scope)
* Don't need to change anything in meaning of current access modifiers
* We even can keep 'fileprivate' as an alias(depricated?) for 'local', so 
we can have 100% source compatibility
* 'local' is very short and good looking keyword, that's important given it 
will be used often
* 'private' still be the most strict access level, soft default. Then you 
can promote to next level('local') if decide you need wider access scope.
* Yes, I remember, 'local' was rejected previously, but world is changing, 
currently many(most?) of us agree that 'fileprivate' more harmful than 
other not clear meaning but good looking word; that 'fileprivate' is still 
used very often and *will* be used often; and IIRC during the SE-0025 there 
was an intention to fix *later* awkward 'fileprivate' keyword, but now we 
was told "this is the last chance, nothing related to access modifiers will 
be in scope of any future Swift and renaming is not in scope of current 
stage also". So given this all, I think we can re-consider 'local' keyword.

Seems like such proposal also will have a huge support of the community.

Btw, when was *that* moment(which most of us missed, as I understand) we 
were *allowed* to discuss access modifier changes?

> or something like that so it can expand it capability as I outline a
> sentence earlier.
>
> This proposal doesn't help like I think a more comprehensive rework would,
> it actually hurts my usage of current private.
>
>
>
> On Thu, Apr 6, 2017 at 4:10 PM Douglas Gregor <dgregor at apple.com
> <mailto:dgregor at apple.com>> wrote:
>
>     Hello Swift community,
>
>     The review of SE-0169 "Improve Interaction Between private Declarations
>     and Extensions" begins now and runs through April 11, 2017. The
>     proposal is available here:
>
>         https://github.com/apple/swift-evolution/blob/master/proposals/0169-improve-interaction-between-private-declarations-and-extensions.md
>
>     Reviews are an important part of the Swift evolution process. All
>     reviews should be sent to the swift-evolution mailing list at
>
>         https://lists.swift.org/mailman/listinfo/swift-evolution
>
>     or, if you would like to keep your feedback private, directly to the
>     review manager. When replying, please try to keep the proposal link at
>     the top of the message:
>
>         Proposal link:
>
>             https://github.com/apple/swift-evolution/blob/master/proposals/0169-improve-interaction-between-private-declarations-and-extensions.md
>
>         Reply text
>
>             Other replies
>
>
>               ________
>               <https://github.com/apple/swift-evolution/blob/master/process.md#what-goes-into-a-review-1>What
>               goes into a review?
>
>     The goal of the review process is to improve the proposal under review
>     through constructive criticism and, eventually, determine the direction
>     of Swift. When writing your review, here are some questions you might
>     want to answer in your review:
>
>       * What is your evaluation of the proposal?
>       * Is the problem being addressed significant enough to warrant a
>         change to Swift?
>       * Does this proposal fit well with the feel and direction of Swift?
>       * If you have used other languages or libraries with a similar
>         feature, how do you feel that this proposal compares to those?
>       * How much effort did you put into your review? A glance, a quick
>         reading, or an in-depth study?
>
>     More information about the Swift evolution process is available at
>
>         https://github.com/apple/swift-evolution/blob/master/process.md
>
>     Thank you,
>
>     -Doug
>
>     Review Manager
>
>     _______________________________________________
>     swift-evolution-announce mailing list
>     swift-evolution-announce at swift.org
>     <mailto:swift-evolution-announce at swift.org>
>     https://lists.swift.org/mailman/listinfo/swift-evolution-announce
>
>
>
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
>