[swift-evolution] [Review] SE-0159: Fix Private Access Levels

[Rien]

> On 23 Mar 2017, at 21:26, Jose Cheyo Jimenez <cheyo at masters3d.com> wrote:
> 
>> 
>> On Mar 23, 2017, at 11:35 AM, Rien via swift-evolution <swift-evolution at swift.org> wrote:
>> 
>> 
>>> On 21 Mar 2017, at 08:05, Rien <rien at balancingrock.nl> wrote:
>>> 
>>> +1
>> 
>> -1: I have revised my opinion.
>> 
>> 
>>> 
>>>> 	• What is your evaluation of the proposal?
>>> 
>>> Makes the language easier to understand, lowers cognitive load during coding.
>>> I also hope this will pave the way for a overhaul of the access level system including modularization.
>> 
>> I still hope that fileprivate will be dumped one day. Presumably when a better proposal is on the table.
>> However it is clear that for some people the disadvantage of dropping it now is bigger than the advantage to the proponents together.
>> Regardless of wether the need is only perceived or not.
>> 
>>> 
>>>> 	• Is the problem being addressed significant enough to warrant a change to Swift?
>>> 
>>> yes.
>> 
>> yes, but not without an alternative solution in place at the time fileprivate is dropped.
> 
> Can you clarify what you mean here? 

Quite obviously the functionality of the current private feature is part of the workflow of a considerable number of people.
It does not really matter if this feature is necessary or not, they have it integrated in their thinking and workflow.
(Note: we don’t need "for element in collection" either, plain "1..N" for loops would suffice)
To me, that is enough reason to postpone this proposal until this functionality can be retained while at the same time reverting private back to its original meaning.

Rien.

> 
>> 
>> 
>>> 
>>>> 	• Does this proposal fit well with the feel and direction of Swift?
>>> 
>>> Yes
>> 
>> Yes
>> 
>>> 
>>>> 	• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>>> 
>>> private vs fileprivate seems swift-only, as such I have no comparison.
>> 
>> Same
>> 
>>> 
>>>> 	• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
>>> 
>>> Followed and participated in the discussions.
>> 
>> 
>> Same.
>> 
>>> 
>>> 
>>> Regards,
>>> Rien
>>> 
>>> Site: http://balancingrock.nl
>>> Blog: http://swiftrien.blogspot.com
>>> Github: http://github.com/Balancingrock
>>> Project: http://swiftfire.nl
>>> 
>>> 
>>> 
>>> 
>>> 
>>>> On 21 Mar 2017, at 00:54, Douglas Gregor via swift-evolution <swift-evolution at swift.org> wrote:
>>>> 
>>>> Hello Swift community,
>>>> 
>>>> The review of SE-0159 "Fix Private Access Levels" begins now and runs through March 27, 2017. The proposal is available here:
>>>> 
>>>> https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md
>>>> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
>>>> 
>>>> https://lists.swift.org/mailman/listinfo/swift-evolution
>>>> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
>>>> 
>>>> Proposal link:
>>>> 
>>>> https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md
>>>> Reply text
>>>> Other replies
>>>> What goes into a review?
>>>> 
>>>> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
>>>> 
>>>> 	• What is your evaluation of the proposal?
>>>> 	• Is the problem being addressed significant enough to warrant a change to Swift?
>>>> 	• Does this proposal fit well with the feel and direction of Swift?
>>>> 	• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>>>> 	• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
>>>> More information about the Swift evolution process is available at
>>>> 
>>>> https://github.com/apple/swift-evolution/blob/master/process.md
>>>> Thank you,
>>>> 
>>>> -Doug
>>>> 
>>>> Review Manager
>>>> 
>>>> _______________________________________________
>>>> swift-evolution mailing list
>>>> swift-evolution at swift.org
>>>> https://lists.swift.org/mailman/listinfo/swift-evolution
>>> 
>> 
>> _______________________________________________
>> swift-evolution mailing list
>> swift-evolution at swift.org
>> https://lists.swift.org/mailman/listinfo/swift-evolution