[swift-evolution] [Review] SE-0159: Fix Private Access Levels

[Christopher Kornher]

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

What is your evaluation of the proposal?
-1 

Is the problem being addressed significant enough to warrant a change to Swift?
Not on its own. I believe that it would be better for the community to handle this as part of a thorough look at Sub Modules and code organization. It is possible that this will be modified yet again when submodules/packages are addressed, creating yet more churn.

Access modifiers should not much of an issue for beginners and small projects. The current rules are useful for large and security-oriented projects. See the response by Drew Crawford.

Does this proposal fit well with the feel and direction of Swift?
File scoping has always seemed like a “C legacy” feature. It encourages large files, which is a problem in MacOS and iOS already. This proposal does nothing to decrease file size and makes file scoping the only way to get private scope. File-based scoping also discourages or at least complicates the development of non file-based and non-textual representations of Swift code

If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
C and other macro-assemblers. Isn’t there a better model out there somewhere?

How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
I read through the proposal, which is pretty straightforward.

> On Mar 20, 2017, at 5:54 PM, Douglas Gregor via swift-evolution <swift-evolution at swift.org> wrote:
> 
> The review of SE-0159 "Fix Private Access Levels" begins now and runs through March 27, 2017. The proposal is available here:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md <https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md>
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170321/f7ae58b5/attachment.html>