[swift-evolution] [Review] SE-0159: Fix Private Access Levels

[Rien]

> On 21 Mar 2017, at 08:55, Goffredo Marocchi <panajev at gmail.com> wrote:
> 
> 
> Sent from my iPhone
> 
>> On 21 Mar 2017, at 07:05, Rien via swift-evolution <swift-evolution at swift.org> wrote:
>> 
>> +1
>> 
>>>   • What is your evaluation of the proposal?
>> 
>> Makes the language easier to understand, lowers cognitive load during coding.
> 
> Is it really a problem for cognitive load during coding? In a world where protocol extensions defined default methods introducing back the nice and easy to understand concept of polymorphism by reference type where casting an instances class that overrides the method declared in the protocol extensions decides which  method is actually executed... well, having to juggle file and scope based access levels breaks the camel's back?

It does not break the camel’s back, but it does lower the load.
I fully well realize that this issue is not a big one and highly personal, and if “fileprivate” remains in use, well, I won’t give up on Swift ;-)

> 
> I remain unconvinced of this, no offense meant Rien.

None taken

Regards,
Rien.

> 
>> I also hope this will pave the way for a overhaul of the access level system including modularization.
>> 
>>>   • Is the problem being addressed significant enough to warrant a change to Swift?
>> 
>> yes.
>> 
>>>   • Does this proposal fit well with the feel and direction of Swift?
>> 
>> Yes
>> 
>>>   • If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>> 
>> private vs fileprivate seems swift-only, as such I have no comparison.
>> 
>>>   • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
>> 
>> Followed and participated in the discussions.
>> 
>> 
>> Regards,
>> Rien
>> 
>> Site: http://balancingrock.nl
>> Blog: http://swiftrien.blogspot.com
>> Github: http://github.com/Balancingrock
>> Project: http://swiftfire.nl
>> 
>> 
>> 
>> 
>> 
>>> On 21 Mar 2017, at 00:54, Douglas Gregor via swift-evolution <swift-evolution at swift.org> wrote:
>>> 
>>> Hello Swift community,
>>> 
>>> The review of SE-0159 "Fix Private Access Levels" begins now and runs through March 27, 2017. The proposal is available here:
>>> 
>>> https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md
>>> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
>>> 
>>> https://lists.swift.org/mailman/listinfo/swift-evolution
>>> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
>>> 
>>> Proposal link:
>>> 
>>> https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md
>>> Reply text
>>> Other replies
>>> What goes into a review?
>>> 
>>> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
>>> 
>>>   • What is your evaluation of the proposal?
>>>   • Is the problem being addressed significant enough to warrant a change to Swift?
>>>   • Does this proposal fit well with the feel and direction of Swift?
>>>   • If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>>>   • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
>>> More information about the Swift evolution process is available at
>>> 
>>> https://github.com/apple/swift-evolution/blob/master/process.md
>>> Thank you,
>>> 
>>> -Doug
>>> 
>>> Review Manager
>>> 
>>> _______________________________________________
>>> swift-evolution mailing list
>>> swift-evolution at swift.org
>>> https://lists.swift.org/mailman/listinfo/swift-evolution
>> 
>> _______________________________________________
>> swift-evolution mailing list
>> swift-evolution at swift.org
>> https://lists.swift.org/mailman/listinfo/swift-evolution