[swift-evolution] [Review] SE-0159: Fix Private Access Levels

[Tony Allevato]

On Mon, Mar 20, 2017 at 4:54 PM Douglas Gregor via swift-evolution <
swift-evolution at swift.org> wrote:

> Hello Swift community,
>
> The review of SE-0159 "Fix Private Access Levels" begins now and runs
> through March 27, 2017. The proposal is available here:
>
>
> https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md
>
> Reviews are an important part of the Swift evolution process. All reviews
> should be sent to the swift-evolution mailing list at
>
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
> or, if you would like to keep your feedback private, directly to the
> review manager. When replying, please try to keep the proposal link at the
> top of the message:
>
> Proposal link:
>
>
> https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md
>
> Reply text
>
> Other replies
>
>
> <https://github.com/apple/swift-evolution/blob/master/process.md#what-goes-into-a-review-1>What
> goes into a review?
>
> The goal of the review process is to improve the proposal under review
> through constructive criticism and, eventually, determine the direction of
> Swift. When writing your review, here are some questions you might want to
> answer in your review:
>
>    - What is your evaluation of the proposal?
>
> Major +1.


>
>    - Is the problem being addressed significant enough to warrant a
>    change to Swift?
>
> Absolutely. Distinguishing between private and fileprivate adds little
value; it mainly serves to protect authors from themselves since it's not
possible for an outside entity to insert its own code into the compilation
unit after it's been compiled*. It's very difficult to see the benefit of
having developers auditing individual members' visibilities to such a fine
degree.

(* The same could be said for file-private because of module boundaries,
but distinguishing between module-restricted and file-restricted has value
for large projects where multiple authors may contribute to the same module
quasi-independently. It's also crucial in code-generation cases like
protocol buffers where the generator doesn't have control over the module
into which the code will be compiled and you still want to be able to use
file-private to hide some details of the generated code from clients in the
same module.)



>
>    - Does this proposal fit well with the feel and direction of Swift?
>
> Yes. One of the most attractive things about Swift's original visibility
model was its simplicity. SE-0025 opened the door to numerous later
informal proposals that would have added even finer distinctions to the
visibility model which would have made the language even more complex.



>
>    - If you have used other languages or libraries with a similar
>    feature, how do you feel that this proposal compares to those?
>
> Earlier versions of Swift.


>
>    - How much effort did you put into your review? A glance, a quick
>    reading, or an in-depth study?
>
>
Followed numerous conversations/threads about the topic and read this
proposal.



> More information about the Swift evolution process is available at
>
> https://github.com/apple/swift-evolution/blob/master/process.md
>
> Thank you,
>
> -Doug
>
> Review Manager
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20170321/8b1f44de/attachment.html>