[swift-evolution] [Review] SE-0144: Allow Single Dollar Sign as a Valid Identifier

[Russ Bishop]

> On Oct 14, 2016, at 12:59 PM, Chris Lattner via swift-evolution <swift-evolution at swift.org> wrote:
> 
> Hello Swift community,
> 
> The review of "SE-0144: Allow Single Dollar Sign as a Valid Identifier" begins now and runs through October 18. The proposal is available here:
> 
> 	https://github.com/apple/swift-evolution/blob/master/proposals/0144-allow-single-dollar-sign-as-valid-identifier.md
> 
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> 
> 	https://lists.swift.org/mailman/listinfo/swift-evolution
> 
> or, if you would like to keep your feedback private, directly to the review manager.
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> 	* What is your evaluation of the proposal?
> 	* Is the problem being addressed significant enough to warrant a change to Swift?
> 	* Does this proposal fit well with the feel and direction of Swift?
> 	* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> 

-1 from me.

The library in question was exploiting a bug in the compiler. I went and checked the officially published Swift 1.0 grammar and “$” is not a valid identifier.

I’m sympathetic to the argument that the behavior shipped in three major versions but ultimately all this does is create an opportunity for cute tricks.

Russ