[swift-evolution] [Review] SE-0122: Use colons for subscript declarations

[David Rönnqvist]

One comment Inline

> On 20 Jul 2016, at 07:58, Charlie Monroe via swift-evolution <swift-evolution at swift.org> wrote:
> 
> I'd personally leave it as is, but am kind of indifferent on the matter.
> 
> The subscript is a hybrid between var and func and with the arguments, it always felt more of a function to me, without them, it felt more like a var to me.
> 
> The logical thing might be to have double-syntax:
> 
> subscript: Int {
>    get { … }
>    set { … }
> }
> 

I've never seen a subscript without parameters before and have a hard time imagining what it would be used for. Wouldn't that be better served with just a property?

> but with parameters, leave the function model:
> 
> subscript(parameter: Int) -> ElementType {
>    get { … }
>    set { … }
> }
> 
> But that brings a certain inconsistency to the language...
> 
> 
>> On Jul 20, 2016, at 7:50 AM, Chris Lattner via swift-evolution <swift-evolution at swift.org> wrote:
>> 
>> Hello Swift community,
>> 
>> The review of "SE-0122: Use colons for subscript declarations " begins now and runs through July 24. The proposal is available here:
>> 
>>    https://github.com/apple/swift-evolution/blob/master/proposals/0122-use-colons-for-subscript-type-declarations.md
>> 
>> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
>> 
>>    https://lists.swift.org/mailman/listinfo/swift-evolution
>> 
>> or, if you would like to keep your feedback private, directly to the review manager.
>> 
>> What goes into a review?
>> 
>> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
>> 
>>    * What is your evaluation of the proposal?
>>    * Is the problem being addressed significant enough to warrant a change to Swift?
>>    * Does this proposal fit well with the feel and direction of Swift?
>>    * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>>    * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
>> 
>> More information about the Swift evolution process is available at
>> 
>>    https://github.com/apple/swift-evolution/blob/master/process.md
>> 
>> Thank you,
>> 
>> -Chris Lattner
>> Review Manager
>> 
>> _______________________________________________
>> swift-evolution mailing list
>> swift-evolution at swift.org
>> https://lists.swift.org/mailman/listinfo/swift-evolution
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution