[swift-evolution] [Review] SE-0122: Use colons for subscript declarations

[Haravikk]

> On 20 Jul 2016, at 06:50, Chris Lattner via swift-evolution <swift-evolution at swift.org> wrote:
> 
> 	* What is your evaluation of the proposal?

I'm leaning towards in favour, but very marginally as to be frank I'm not that bothered either way. The subscript is a definite hybrid of property and function, but then so is a computed property, only the subscript has the possibility of arguments, which makes it slightly more function oriented.

So I don't know, I'd say the fact that a subscript with setter makes it more like a property overall, but again it's a very slim difference.

> 	* Is the problem being addressed significant enough to warrant a change to Swift?

Not really; I don't think anyone is losing any sleep over having to use function style declaration. It might be a little easier for newbies to use the colon, but I'm not sure as the duality doesn't make either style a clear winner; really we'd need more information about which people find easier to use.

> 	* Does this proposal fit well with the feel and direction of Swift?

Both styles are Swifty, this may be very marginally better, but it's a tough call.
> 
> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Quick read, it's pretty straightforward though.