[swift-evolution] [Review] SE-0120: Revise 'partition' Method Signature

[Dave Abrahams]

on Tue Jul 12 2016, Jacob Bandes-Storch <swift-evolution at swift.org> wrote:

>>
>> Proposal link:
>>
>> https://github.com/apple/swift-evolution/blob/master/proposals/0120-revise-partition-method.md
>>
>>         * What is your evaluation of the proposal?
>>
>
> +1, although I don't think the functions should be marked with
> @discardableResult. The partition method is hardly useful if you don't know
> where the partition index is.

That's a very good point.

>>         * Is the problem being addressed significant enough to warrant a
>> change to Swift?
>>
>
> Somewhat. This API isn't commonly used (I've never used it), but APIs in
> the standard library deserve to make sense and be useful :-)
>
>>         * Does this proposal fit well with the feel and direction of Swift?
>>
>
> Yes, the new API seems to feel "Swifty", and conform to the API design
> guidelines.
>
>>         * If you have used other languages or libraries with a similar
>> feature, how do you feel that this proposal compares to those?
>>
>
> N/A
>
>>         * How much effort did you put into your review? A glance, a quick
>> reading, or an in-depth study?
>
> Brief reading of the proposal and a look at the existing API. I've never
> used this API in Swift.
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
>

-- 
Dave