[swift-evolution] [Idea] Wrap switch cases in curly braces

[G B]

The same can be said for if/else constructs though— all those braces get heavy if they’re all wrapping one line each.  Python does away with the braces and relies on indentation, but Swift has explicitly stated that it will not follow that path— yet case statements seem an exception.  It’s a collection of statements, they should be grouped in braces.

Your example is still only one line per case, but those braces are less of a problem when amortized over more lines (note that there are extra braces enforced by the `if` and `else`):

switch x {
case 0 {
    //a comment or two describing what's happening in this particular case
    //because commenting is good practice
    result=runSomeCode()
    if result {
        //do something here
    }
    else {
        //maybe some more stuff
        print(0)
    }
}

case 1 {
    //a comment or two describing what's happening in this particular case
    //because commenting is good practice
    result=runSomeCode()
    if result {
        //do something here
    }
    else {
        //maybe some more stuff
        print(1)
    }
}

case 2 {
    //a comment or two describing what's happening in this particular case
    //because commenting is good practice
    result=runSomeCode()
    if result {
        //do something here
    }
    else {
        //maybe some more stuff
        print(2)
    }
}

default {
    //a comment or two describing what's happening in this particular case
    //because commenting is good practice
    result=runSomeCode()
    if result {
        //do something here
    }
    else {
        //maybe some more stuff
        print(0)
    }
}
}



> On Jul 7, 2016, at 13:24 , Brandon Knope <bknope at me.com> wrote:
> 
> When each case only takes up one line, it may look nice and concise. But what happens in the common case when your case takes up more lines and you indent your braces?
> 
>> switch x {
>> case 0 { print(0) }
>> case 1 { print(1) }
>> case 2 { print(2) }
>> default { print("other”) }
>> }
> 
> switch x {
> case 0 { 
>     print(0) 
> }
> case 1 { 
>     print(1) 
> }
> case 2 { 
>     print(2)
> }
> default { 
>     print("other”) 
> }
> }
> 
> I think this looks much heavier and harder to read.  All the braces detract from the important stuff
> 
> Brandon 
> 
> 
> 
>> 
>> The colon syntax evokes a label, but the modern, complex `case` statements in Swift don’t act much like labels.
>> _______________________________________________
>> swift-evolution mailing list
>> swift-evolution at swift.org <mailto:swift-evolution at swift.org>
>> https://lists.swift.org/mailman/listinfo/swift-evolution <https://lists.swift.org/mailman/listinfo/swift-evolution>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160707/fde63bb5/attachment.html>