[swift-evolution] [Review] SE-0118: Closure Parameter Names and Labels

[David Rönnqvist]

>    * What is your evaluation of the proposal?

+1. These look like good improvements to me. (I'm also happy that the map/filter/reduce naming was left out of this proposal)

One thing I was wonder about was the capitalization of UTF8 in the first example. Shouldn't that be s.withUTF8Buffer(processBytes)instead of s.withUtf8Buffer(processBytes) or am I confusing Swift's conventions with Cocoa's?

>    * Is the problem being addressed significant enough to warrant a change to Swift?

Yes. Inconsistency at this point in Swifts evolution should be dealt with.

>    * Does this proposal fit well with the feel and direction of Swift?

Yes. These proposed labels help the call site read better as a sentence.

>    * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

Not applicable

>    * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?


Quick reading of the proposal. Followed some of the discussion.

- David

> On 6 Jul 2016, at 01:10, Chris Lattner via swift-evolution <swift-evolution at swift.org> wrote:
> 
> Hello Swift community,
> 
> The review of "SE-0118: Closure Parameter Names and Labels" begins now and runs through July 11. The proposal is available here:
> 
>    https://github.com/apple/swift-evolution/blob/master/proposals/0118-closure-parameter-names-and-labels.md
> 
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> 
>    https://lists.swift.org/mailman/listinfo/swift-evolution
> 
> or, if you would like to keep your feedback private, directly to the review manager.
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
>    * What is your evaluation of the proposal?
>    * Is the problem being addressed significant enough to warrant a change to Swift?
>    * Does this proposal fit well with the feel and direction of Swift?
>    * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>    * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> 
> More information about the Swift evolution process is available at
> 
>    https://github.com/apple/swift-evolution/blob/master/process.md
> 
> Thank you,
> 
> -Chris Lattner
> Review Manager
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160706/629b0c85/attachment.html>