[swift-evolution] [Review] SE-0117: Default classes to be non-subclassable publicly
Jacopo Andrea Giola
swift-evolution at jacopo.giola.org
Wed Jul 6 07:23:07 CDT 2016
> * What is your evaluation of the proposal?
Strong +1 with the modifications proposed by Brent, I think that a single, short keyword is preferable to two different ones, and `open` is a perfect candidate that express its intent very well.
The only question that it raises is, a public class can be extended with a protocol defined in another module? I think that this aspect is not addresses in the proposal, or I have missed it completely.
> * Is the problem being addressed significant enough to warrant a change to Swift?
> * Does this proposal fit well with the feel and direction of Swift?
Yes indeed! This will fit nicely with the secure aspect of the Swift language, and will avoid cases where the library authors will try to discourage subclassing inside the comments in the class declaration file.
> * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
I’ve read the proposal
More information about the swift-evolution